Support path-like filenames in edit#3684
Closed
arturict wants to merge 1 commit into
Closed
Conversation
Author
|
Closing after finding the project's maintainer guidance that AI-generated contributions are not wanted. Sorry for missing that before opening this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
os.PathLike[str]or an iterable containing path-like filenames inclick.editos.fspathbefore invoking the editorWhy
click.edit(filename=Path(...))was rejected by type checkers and treated the path as an iterable at runtime. This makes the public API consistent with other Click file APIs that already accept path-like objects.Fixes #2869
Validation
uv run --frozen pytest -q— 1832 passed, 95 skipped, 1 xfaileduv run --frozen ruff check src testsuv run --frozen mypy tests/typing/typing_termui.pygit diff --check