Fix progressbar final position with update_min_steps#3691
Open
l46983284-cpu wants to merge 1 commit into
Open
Conversation
Apply pending steps in finish() so show_pos reaches length/length when the last interval is below update_min_steps. Fixes pallets#3571 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
update_min_stepsholds back the final partial interval,finish()marked the bar complete without applying those steps. Percentage display still looked finished becausefinishedforces 100%, butshow_poskept the last flushed position (for example14/20).Apply any pending
_completed_intervalsinfinish()before the final render soshow_posreacheslength/length.fixes #3571