-
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Docs: add context to Incoming Request Data section #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding consistency with other sections. The 'Sessions' section (lines 59-67) and 'Application Globals' section (lines 151-156) also have introductory paragraphs. However, 'Application Object', 'Blueprint Objects', and 'Response Objects' sections do not. While this addition is helpful, it creates inconsistency. Consider either adding similar introductions to other major sections or ensuring the current style aligns with the documentation's overall approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out — that’s a fair observation.
My intention was to add a small amount of context in a section that currently
jumps straight into the API reference, similar to how the Sessions and
Application Globals sections provide brief introductions.
Since this is my first contribution, I tried to keep the scope limited to a
single section to avoid larger stylistic changes. That said, I’m happy to
either adjust the wording to better match the existing approach, or add similar
introductory context to other major sections (such as Application Object,
Blueprint Objects, and Response Objects) if that would be preferred.
Please let me know which direction you’d recommend.