Skip to content

Abort if the instance folder cannot be created#5903

Merged
davidism merged 1 commit into
pallets:stablefrom
marcows:instance-folder
Jan 28, 2026
Merged

Abort if the instance folder cannot be created#5903
davidism merged 1 commit into
pallets:stablefrom
marcows:instance-folder

Conversation

@marcows
Copy link
Copy Markdown
Contributor

@marcows marcows commented Jan 27, 2026

According to the comment, the instance folder should exist in any case. But a PermissionError was ignored silently.

Since Python 3.9 is the minimum required version, it is safe to use "exist_ok" added in Python 3.2 and avoid exception handling.

According to the comment, the instance folder should exist in any case.
But a PermissionError was ignored silently.

Since Python 3.9 is the minimum required version, it is safe to use
"exist_ok" added in Python 3.2 and avoid exception handling.
@davidism davidism added the docs label Jan 27, 2026
@davidism
Copy link
Copy Markdown
Member

Make sure you update the code in the examples dir as well. Does any surrounding text need to be updated? Docs changes should be targetted at stable, so that they're available in the current docs.

@marcows marcows changed the base branch from main to stable January 28, 2026 06:42
@marcows
Copy link
Copy Markdown
Contributor Author

marcows commented Jan 28, 2026

My branch was already based on stable, but it got wrong in the PR. I fixed that.

Code in examples/ had already been updated, no further surrounding text needs changes, even the os.makedirs description further below fits better than before.

The surrounding code in examples/ already wasn't in sync with the docs, though.

@davidism davidism merged commit 4e652d3 into pallets:stable Jan 28, 2026
14 checks passed
@marcows marcows deleted the instance-folder branch January 28, 2026 22:33
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants