Reduce dispatch_request processing time by 8%#5939
Closed
dalekube wants to merge 5 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach safely handles view_functions regardless of how they were registered (via add_url_rule, Blueprint registrations, or direct mutation) while achieving the performance goals of reducing hot-path introspection. The iscoroutinefunction method requires unwrapping decorators (using inspect.unwrap) and checking internal code flags, and it is relatively expensive in Python.
Current Estimated Performance
Total time: 9.5344 seconds (for 100,000 iterations)
Performance: 10,488.30 requests / second
Time/Req: 95.34 microseconds
New Estimated Performance
Total time: 8.7554 seconds (for 100,000 iterations)
Performance: 11,421.47 requests / second
Time/Req: 87.55 microseconds
The optimization caches the results of app.ensure_sync (which otherwise checks asyncio.iscoroutinefunction repeatedly), the difference in these numbers represents the CPU overhead eliminated during the dispatch phase.