Skip to content

Commit f422a5d

Browse files
jbrockmendelclaude
andauthored
TST/CLN: salvage or remove FIXME-commented-out tests (#65476)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 20ebcfb commit f422a5d

5 files changed

Lines changed: 15 additions & 29 deletions

File tree

pandas/tests/frame/test_block_internals.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -196,23 +196,29 @@ def test_construction_with_conversions(self):
196196
{
197197
"dt1": Timestamp("20130101").as_unit("s"),
198198
"dt2": date_range("20130101", periods=3).astype("M8[s]"),
199-
# 'dt3' : date_range('20130101 00:00:01',periods=3,freq='s'),
200-
# FIXME: don't leave commented-out
199+
"dt3": date_range("20130101 00:00:01", periods=3, freq="s").astype(
200+
"M8[s]"
201+
),
201202
},
202203
index=range(3),
203204
)
204205
assert expected.dtypes["dt1"] == "M8[s]"
205206
assert expected.dtypes["dt2"] == "M8[s]"
207+
assert expected.dtypes["dt3"] == "M8[s]"
206208

207209
dt1 = np.datetime64("2013-01-01")
208210
dt2 = np.array(
209211
["2013-01-01", "2013-01-02", "2013-01-03"], dtype="datetime64[D]"
210212
)
211-
df = DataFrame({"dt1": dt1, "dt2": dt2})
212-
213-
# df['dt3'] = np.array(['2013-01-01 00:00:01','2013-01-01
214-
# 00:00:02','2013-01-01 00:00:03'],dtype='datetime64[s]')
215-
# FIXME: don't leave commented-out
213+
dt3 = np.array(
214+
[
215+
"2013-01-01 00:00:01",
216+
"2013-01-01 00:00:02",
217+
"2013-01-01 00:00:03",
218+
],
219+
dtype="datetime64[s]",
220+
)
221+
df = DataFrame({"dt1": dt1, "dt2": dt2, "dt3": dt3})
216222

217223
tm.assert_frame_equal(df, expected)
218224

pandas/tests/io/formats/test_format.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,10 +1286,6 @@ def test_info_repr_max_cols(self):
12861286
):
12871287
assert not has_non_verbose_info_repr(df)
12881288

1289-
# FIXME: don't leave commented-out
1290-
# test verbose overrides
1291-
# set_option('display.max_info_columns', 4) # exceeded
1292-
12931289
def test_pprint_pathological_object(self):
12941290
"""
12951291
If the test fails, it at least won't hang.

pandas/tests/io/formats/test_to_string.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -857,10 +857,7 @@ def test_to_string(self):
857857
tm.assert_series_equal(recons["B"], biggie["B"])
858858
assert recons["A"].count() == biggie["A"].count()
859859
assert (np.abs(recons["A"].dropna() - biggie["A"].dropna()) < 0.1).all()
860-
861-
# FIXME: don't leave commented-out
862-
# expected = ['B', 'A']
863-
# assert header == expected
860+
assert header == ["B", "A"]
864861

865862
result = biggie.to_string(columns=["A"], col_space=17)
866863
header = result.split("\n")[0].strip().split()

pandas/tests/io/test_stata.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -211,16 +211,7 @@ def test_read_dta2(self, datapath):
211211
parsed_115 = self.read_dta(path2)
212212
with tm.assert_produces_warning(UserWarning, match=msg):
213213
parsed_117 = self.read_dta(path3)
214-
# FIXME: don't leave commented-out
215-
# 113 is buggy due to limits of date format support in Stata
216-
# parsed_113 = self.read_dta(
217-
# datapath("io", "data", "stata", "stata2_113.dta")
218-
# )
219-
220-
# FIXME: don't leave commented-out
221-
# buggy test because of the NaT comparison on certain platforms
222-
# Format 113 test fails since it does not support tc and tC formats
223-
# tm.assert_frame_equal(parsed_113, expected)
214+
224215
tm.assert_frame_equal(parsed_114, expected)
225216
tm.assert_frame_equal(parsed_115, expected)
226217
tm.assert_frame_equal(parsed_117, expected)

pandas/tests/resample/test_period_index.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -459,10 +459,6 @@ def test_resample_to_quarterly_start_end(self, simple_period_range_series, how):
459459
expected = ts.asfreq("Q-MAR", how=how)
460460
expected = expected.reindex(result.index, method="ffill")
461461

462-
# FIXME: don't leave commented-out
463-
# .to_timestamp('D')
464-
# expected = expected.resample('Q-MAR').ffill()
465-
466462
tm.assert_series_equal(result, expected)
467463

468464
def test_resample_fill_missing(self):

0 commit comments

Comments
 (0)