BUG: Index.get_indexer matches pd.NA against NaN for list input but not ndarray input #65419#65442
Open
sayantancodex wants to merge 16 commits into
Open
BUG: Index.get_indexer matches pd.NA against NaN for list input but not ndarray input #65419#65442sayantancodex wants to merge 16 commits into
sayantancodex wants to merge 16 commits into
Conversation
Member
|
Can you get the tests passing |
…ng fillna(np.nan)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an inconsistency in
Index.get_indexerwherepd.NAwas not matched againstNaNlabels in object-dtype indexes when the target was anndarrayor anIndex.The fix involves normalizing
pd.NAtonp.nanin_maybe_cast_listlike_indexerfor object-dtype indexes, which aligns the behavior of array-like inputs with the existing behavior for list-like inputs andget_locscalar lookups.Changes
pandas/core/indexes/base.pyto ensure consistent null normalization during indexer casting.pandas/tests/indexes/base/test_get_indexer_na.py.v3.1.0.rstwhatsnew file.