Implement docked variant for Drawer#696
Open
philippjfr wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
===========================================
+ Coverage 71.24% 85.06% +13.81%
===========================================
Files 33 33
Lines 3822 3823 +1
===========================================
+ Hits 2723 3252 +529
+ Misses 1099 571 -528 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The docked variant uses a persistent MUI Drawer under the hood but wraps it in fixed positioning with a DockedTab component. When the drawer is closed, only the tab is visible flush against the viewport
edge. When open, the tab attaches to the drawer's outer border (offset by 1px to avoid overlapping the border line) and switches its chevron direction to indicate it will close.
The dock_position parameter allows positioning the tab at the start, middle (default), or end of the drawer edge, accommodating different layout needs (e.g. placing it near a header or footer).