Traitlet injection fails with chained functions (e.g. beam resource hints)#102
Draft
jbusecke wants to merge 4 commits into
Draft
Traitlet injection fails with chained functions (e.g. beam resource hints)#102jbusecke wants to merge 4 commits into
jbusecke wants to merge 4 commits into
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 95.75% 95.37% -0.39%
==========================================
Files 13 13
Lines 424 432 +8
==========================================
+ Hits 406 412 +6
- Misses 18 20 +2
☔ View full report in Codecov by Sentry. |
Member
|
@jbusecke tests pass here (edit: except codecov...) so you could try merging this into your |
Author
I think I am tending towards that for now, but might reconsider if big requests come in. Thanks for your work here! |
Author
|
I think this feature might be useful for leap-stc/data-management#57. |
Contributor
|
Looks to me like a potential symptom of this problem: #168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cisaacstern and I just went on a bit of a deep dive to debug failures (example) over at cmip6-leap-feedstock, and discovered that the traitlet injection was failing for stages with resource hints like this:
This PR adds a minimal failing example for the
test_rewriter.pymodule.