Skip to content

Add Config to Pass Around Injected Args#146

Open
ranchodeluxe wants to merge 3 commits into
mainfrom
gcorradini/configject
Open

Add Config to Pass Around Injected Args#146
ranchodeluxe wants to merge 3 commits into
mainfrom
gcorradini/configject

Conversation

@ranchodeluxe
Copy link
Copy Markdown
Collaborator

@ranchodeluxe ranchodeluxe added test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test. labels Nov 20, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90479ab) 96.31% compared to head (a5ca82c) 96.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          15       15           
  Lines         489      489           
=======================================
  Hits          471      471           
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisaacstern
Copy link
Copy Markdown
Member

IIUC, this should not be necessary, providing pangeo-forge/pangeo-forge-recipes#652 correctly defines injection specs for Config (which it does). The explicit specs here are for backwards-compatibility for pangeo-forge-recipes releases which predate the injection system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-dataflow Add this label to PRs to trigger Dataflow integration test. test-flink Add this label to PRs to trigger Dataflow integration test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants