Delegate bakery implementation-specifics to bakeries#175
Open
moradology wants to merge 6 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Contributor
Author
|
Apologies for the chatter/failing CI, my pytest locally is using obviously cached files and though I've burned pyc and pycache, it persists in running old code 😭 EDIT: Just to be clear, this was hopeless stupidity on my part. Forgot the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 95.53% 94.80% -0.73%
==========================================
Files 14 15 +1
Lines 493 520 +27
==========================================
+ Hits 471 493 +22
- Misses 22 27 +5 ☔ View full report in Codecov by Sentry. |
91bc316 to
96d9afa
Compare
Contributor
Author
|
Traitlets is a cruel master. Where in the hell are the post_init hooks? How could they build a validation library without them!? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up
Bake.pyas it is central to the library's functionality. To this end,Bakeryimplementation specifics are handled by the bakeries themselves. There are two central components to this change:bakery.bakeis now used to delegate the specifics of running a pipeline to the bakeries themselves