Skip to content

Add Windows executable builds to the CI workflow.#221

Draft
coco-314 wants to merge 31 commits into
panglesd:mainfrom
coco-314:feature/ci-add-windows-exe
Draft

Add Windows executable builds to the CI workflow.#221
coco-314 wants to merge 31 commits into
panglesd:mainfrom
coco-314:feature/ci-add-windows-exe

Conversation

@coco-314
Copy link
Copy Markdown

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 86926faf-39ba-4bb3-a6c9-91850c91cce6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@panglesd
Copy link
Copy Markdown
Owner

Thanks! Being able to build slipshow for Windows will be a nice step toward good Windows support!

Comment thread .github/workflows/build.yaml Outdated
run: git fetch --tags --force origin

- name: Install OCaml ${{ matrix.ocaml-compiler }}
uses: ocaml/setup-ocaml@v2
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is probably that v2 is an old version that used to go through hoops to work on windows, and the hoops have been removed. While the version 3 uses the now better Windows support from opam.

Suggested change
uses: ocaml/setup-ocaml@v2
uses: ocaml/setup-ocaml@v3

@panglesd panglesd force-pushed the feature/ci-add-windows-exe branch from 097cefd to a826bd3 Compare April 9, 2026 14:14
@panglesd panglesd force-pushed the feature/ci-add-windows-exe branch from a826bd3 to 7a7bf33 Compare April 9, 2026 14:18
@panglesd panglesd force-pushed the feature/ci-add-windows-exe branch from 285965a to 9e4192a Compare April 10, 2026 13:12
ocaml-compiler: 4.14
opam-pin: false
opam-repositories: |
default: https://github.com/punchagan/opam-repository.git#f1c70a26b442142ba1c3bd040bf8621060c94912
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has now been merged upstream, and this change to use a different version of the repository can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants