Skip to content

test(filesystem): expand remote emulator integration coverage - #273

Merged
amotl merged 1 commit into
mainfrom
test/remote-filesystem-matrix
Aug 3, 2026
Merged

test(filesystem): expand remote emulator integration coverage#273
amotl merged 1 commit into
mainfrom
test/remote-filesystem-matrix

Conversation

@hampsterx

@hampsterx hampsterx commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add xdist-safe, controller-managed S3, Azure, and GCS emulators with pinned images.
  • Cover remote formats, compression, globs, failures, native destination writes, cross-provider round trips, and S3 incremental loading.
  • Refresh S3 listings between repeated loads and support Azure destination connection strings.
  • Avoid emulator startup for unrelated targeted tests while keeping the fast lane Docker-free.
  • Document Azure connection-string authentication, credential exclusivity, and repeated S3 load behavior.

Scope

Changes

  • Share one controller-managed emulator container per backend across xdist workers.
  • Add remote read, write, selection, failure, round-trip, and incremental integration coverage.
  • Disable S3 listings caching so repeated incremental loads discover new objects.
  • Add Azure destination connection-string support and reject mixed Azure credential modes.
  • Document the new Azure authentication path and validation behavior.

Review

  • Internal: one correctness fix and three consistency fixes applied.
  • Claude: no defects; applied its api_version documentation and parsed pytest-target suggestions. Two scope/refactor suggestions were noted.
  • Open-weights GLM: final focused review reported no significant findings. Its earlier agentic pass raised only low/informational notes.
  • Codex: skipped because it is the same harness performing this workflow.

Test plan

  • Serial integration: 20 passed in 3m 38s.
  • Final default xdist run: 20 passed in 2m 22s, with one container per backend.
  • Docker-disabled fast lane: 884 passed, 44 skipped.
  • Isolated spreadsheet lane: 41 passed.
  • Ruff formatting/lint, ty, and pyproject validation.
  • Exact gitleaks CI container command, no leaks found.
  • Sphinx warning-as-error build.
  • Breaking the Azure destination credential path makes the write test fail, verified manually.
  • Claude and GLM final-diff review.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b03ad3f1-9e1b-4393-9eca-9503942bb4b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@read-the-docs-community

read-the-docs-community Bot commented Aug 2, 2026

Copy link
Copy Markdown

Documentation build overview

📚 omniload | 🛠️ Build #33880179 | 📁 Comparing f7ac9d0 against latest (747b6aa)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

@hampsterx
hampsterx force-pushed the test/remote-filesystem-matrix branch from 973075e to 371d62c Compare August 2, 2026 23:18
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.52%. Comparing base (7e3d5f8) to head (f7ac9d0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   59.45%   59.52%   +0.07%     
==========================================
  Files         234      234              
  Lines       10977    10992      +15     
==========================================
+ Hits         6526     6543      +17     
+ Misses       4451     4449       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hampsterx
hampsterx force-pushed the test/remote-filesystem-matrix branch 3 times, most recently from 49915a0 to 0d885f2 Compare August 2, 2026 23:49

@amotl amotl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another wonderful cleanup & bundling patch from your pen, thank you!
Acknowledged modulo fixing CI.

@hampsterx
hampsterx force-pushed the test/remote-filesystem-matrix branch from 0d885f2 to 7963a06 Compare August 3, 2026 00:12
@amotl

amotl commented Aug 3, 2026

Copy link
Copy Markdown
Member

Currently the branch seems to have conflicts, so the CI workflow didn't start at all after your recent adjustments.

- Add xdist-safe, controller-managed S3, Azure, and GCS emulators with pinned images.
- Cover remote formats, compression, globs, failures, native destination writes, cross-provider round trips, and S3 incremental loading.
- Refresh S3 listings between repeated loads and support Azure destination connection strings.
- Avoid emulator startup for unrelated targeted tests while keeping the fast lane Docker-free.
- Document Azure connection-string authentication and repeated S3 load behavior.
@hampsterx
hampsterx force-pushed the test/remote-filesystem-matrix branch from 7963a06 to f7ac9d0 Compare August 3, 2026 00:58
@amotl
amotl merged commit e7ee73f into main Aug 3, 2026
14 checks passed
@amotl
amotl deleted the test/remote-filesystem-matrix branch August 3, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filesystem: Integration tests for remote filesystems

2 participants