Slack php notices#131
Open
ultimike wants to merge 2 commits into
Open
Conversation
ataylorme
suggested changes
Mar 27, 2018
Contributor
ataylorme
left a comment
ataylorme
left a comment
There was a problem hiding this comment.
Hi @ultimike - thanks for the PR! Rather than removing $secrets['slack_channel'] let's add it to the _get_secrets call and pass it to all instances of _slack_notification. Slack needs to know what channel to send the message to!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a couple of PHP Notices that should be fixed.
When sending a notification of a clear_cache event, there is no $test defined.
The
$secrets['slack_channel']variable appears to be unused, so let's remove it.-mike