Introduce Version Tool into Build Tools.#331
Open
rvtraveller wants to merge 10 commits into
Open
Conversation
Contributor
|
@rvtraveller made some changes - @greg-1-anderson could you review if this is good to be merged now? Thank you! |
| $application = $info->application(); | ||
| $version = $info->version(); | ||
| $major_version = explode(".", $version); | ||
| $framework = $application == "WordPress" ? "empty-wordpress" : ( |
Contributor
There was a problem hiding this comment.
This could be a little more verbose for readability. Maybe break it out into its own function where you can use the pattern if (cond) { return } to avoid nesting and ternary operators.
| $data = [ | ||
| 'application' => $info['application'], | ||
| 'version' => $info['version'], | ||
| 'major-version' => $info['major_version'], |
Contributor
There was a problem hiding this comment.
If we used $info['major-version'] instead of major_version throughout the code, then we could just return $info here without having to create a mapping like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's introduce the Version Tool package into Build Tools so we can leverage it in other PRs or work we're doing.
This includes a
build:project:versioncommand which is largely available just for testing purposes.