Allow config-based overrides of github server hostname#449
Open
benjaminbradley wants to merge 1 commit into
Open
Allow config-based overrides of github server hostname#449benjaminbradley wants to merge 1 commit into
benjaminbradley wants to merge 1 commit into
Conversation
kporras07
requested changes
May 2, 2022
| public function __construct(Config $config) | ||
| { | ||
| parent::__construct($config); | ||
| $privateGithub = $this->config->get('build-tools.provider.git.github.url'); |
Member
There was a problem hiding this comment.
This looks great, but there's an underlying issue that makes this not work with env vars as described in this PR: #187
Could you please update this line to be:
$privateGithub = $this->config->get('build-tools.provider.git.github.url') ?? getenv('TERMINUS_BUILD_TOOLS_PROVIDER_GIT_GITHUB_URL') ?? null;
so that this env var (TERMINUS_BUILD_TOOLS_PROVIDER_GIT_GITHUB_URL) can be used to override this behavior easily in CI?
Thanks!
Once merged, I'll create a follow-up PR to set that var when creating a project from scratch and I will probably request help to test it, it would be great if you can help with that at that time :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.