[BUGS-10991] Extract waitForCommit into reusable utility class#2789
Open
greg-1-anderson wants to merge 1 commit into
Open
[BUGS-10991] Extract waitForCommit into reusable utility class#2789greg-1-anderson wants to merge 1 commit into
greg-1-anderson wants to merge 1 commit into
Conversation
Move the commit-waiting logic from WaitCommand into a static method in Helpers\Utility\WaitForCommit so it can be called from outside the command context. The WaitCommand now delegates to the utility, passing in the Request and Logger dependencies explicitly.
3 tasks
greg-1-anderson
changed the title
jazzsequence
approved these changes
Mar 4, 2026
namespacebrian
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude's implementation of my idea, which is essentially the same as @stevector 's idea. The basic idea here is to make a new Terminus release with a utility class that the Build Tools plugin can use, and then make a new version of the Build Tools plugin that requires this new Terminus release.
Summary
waitForCommitlogic fromWaitCommandinto a standalone static method inPantheon\Terminus\Helpers\Utility\WaitForCommit.RequestandLoggerInterfaceas explicit parameters, making it callable from outside the command context.WaitCommand::waitForCommit()now delegates to the utility class, preserving existing behavior.Test plan
workflow:wait --commit <sha>command still works as before.RequestandLoggerInterfaceinstance.