[SITE-5793] Fix script injection in build-tag-release workflow#373
Open
AnaisPantheor wants to merge 1 commit into
Open
[SITE-5793] Fix script injection in build-tag-release workflow#373AnaisPantheor wants to merge 1 commit into
AnaisPantheor wants to merge 1 commit into
Conversation
Up to standards ✅🟢 Issues
|
jazzsequence
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${{ steps.get-changed-files.outputs.all }}fromrun:block toenv:block in build-tag-release.ymlWhy
Using
${{ }}expressions directly insiderun:blocks is a script injection vulnerability. The step output contains filenames that are interpolated directly into the shell, including inside aforloop. Filenames containing shell metacharacters could be interpreted as commands.The secure pattern is to pass values through
env:blocks, where they become shell variables instead of being interpolated into the script before shell parsing.Test plan