Cherry pick valyala/fastjson/pull/87#1
Merged
Conversation
kouknick
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes non-printable UTF-8 fastjson artifacts.
This is a cherry-pick of the PR valyala#87 that fixes issue valyala#90
Note that in order to trigger this bug when actually Parsing a json payload (instead of just using a string as displayed in the description of valyala#90) you need to
Visit()the problematic string key and doType()on it.Type()has side effects.There is also an extra commit with tests that break without the changes.