Dark mode UI by awilliansd · Pull Request #859 · paolosalvatori/ServiceBusExplorer

awilliansd · 2026-03-12T01:21:04Z

Add Dark/Light Theme Toggle

Summary

Adds a runtime dark/light theme toggle to Service Bus Explorer.
Default is dark, switchable via View → Theme → Dark / Light, with persistence across sessions.

Changes

New

Helpers/ThemeManager.cs — theming engine (recursive apply, persistence, custom control support)
Helpers/MainFormThemeExtension.cs — menu injection + native dark title bar

Updated

MainForm.cs — initializes theming
All Forms and UserControls — apply theme after InitializeComponent()
All .Designer.cs — neutralized hardcoded colors

Technical Overview

Recursive theming via ThemeManager.Apply(Control)
Runtime switching with SetTheme / Toggle
Reapplies theme to all open forms
Preference persisted via ConfigurationManager
Custom control support via reflection
Dark rendering for ToolStrip, MenuStrip, TabControl
Native dark title bar (Windows 10 1903+ via DWM)

Themes

Dark

Background: #212121
Surface: #2A2A2A
Border: #484848
Text: #ECECEC
Accent: #007ACC

Light

Uses SystemColors (native Windows appearance)

Notes

UI-only change (no impact on logic)
AboutForm excluded due to custom background
Azure logo uses fixed background for visibility

Testing

Verified on Windows 11 (.NET Framework 4.7.2)
All forms render correctly in both themes
Theme persists after restart

SeanFeldman

@awilliansd there are a few comments that apply to multiple places.
Also, the screenshots are missing.
The AI-generated documentation has the "Build script" section, mentioning a build script build-dark-theme.ps1, but that's not in the PR. Nor should there be, as it should work with the existing build infrastructure.

awilliansd · 2026-03-12T16:35:10Z

I've fixed the comments, added the script I used, and refactored several times. I've also added screenshots in the folder. Sorry for my mistake. Thanks for the feedback.

SeanFeldman · 2026-03-30T05:27:44Z

@paolosalvatori and @ErikMogensen, a nice UI update for those that crave dark mode. Thoughts?

paolosalvatori · 2026-03-30T08:16:03Z

If the feature works as expected, I'm more than happy to approve and merge it. Did you guys tried it @SeanFeldman / @ErikMogensen?

ErikMogensen · 2026-03-21T14:28:16Z

+            var color = e.Item.Selected
+                ? ThemeManager.SurfaceLighter
+                : ThemeManager.SurfaceLight;
+            e.Graphics.FillRectangle(new SolidBrush(color), e.Item.ContentRectangle);


The SolidBrush is not being disposed of. Unlike above where you are using a using statement.

ErikMogensen · 2026-03-21T14:28:27Z

+        }
+
+        protected override void OnRenderToolStripBackground(ToolStripRenderEventArgs e)
+            => e.Graphics.FillRectangle(new SolidBrush(ThemeManager.Surface), e.AffectedBounds);


ErikMogensen · 2026-03-21T14:28:36Z

+            if (e.Item.Selected || e.Item.Pressed)
+            {
+                var color = e.Item.Pressed ? ThemeManager.Accent : ThemeManager.SurfaceLighter;
+                e.Graphics.FillRectangle(new SolidBrush(color), new Rectangle(Point.Empty, e.Item.Size));


ErikMogensen · 2026-03-21T14:32:49Z

+        {
+            ApplyToControl(control);
+            ApplyRecursive(control);
+            control.ControlAdded += (s, e) => ApplyRecursive(e.Control);


Each Apply() call (e.g., during Toggle()/SetTheme()) adds another handler. After toggling twice, every new control added gets themed twice. Guard against this or unsubscribe first.

I changed duplicate event subscriptions in ThemeManager.Apply

ErikMogensen · 2026-03-21T14:35:19Z

+            MainFormThemeExtension.InitTheme(this, mainMenuStrip);
+            ThemeManager.Apply(this);


InitTheme(MainForm, MenuStrip) already calls ThemeManager.Apply(form) . The second call in MainForm's constructor (line after) is a duplicate that also registers a second ControlAdded handler.

ErikMogensen · 2026-03-30T20:51:57Z

I think it is a very cool feature. I started a build from the branch but the Themes menu item was not visible when I ran it. I haven't looked into it so it may be something on my side.

@awilliansd, since normally application default to the light theme I think we should stick to that.

…commit includes:\n- Translation of theme manager components to English\n- Updates to EventGrid library files\n- Improvements to ContainerForm UI layout\n- Enhancements to various controls (HandleEventGridSubscriptionControl, HandleQueueControl)\n- Dark mode implementation refinements

awilliansd · 2026-03-30T22:40:15Z

I think it is a very cool feature. I started a build from the branch but the Themes menu item was not visible when I ran it. I haven't looked into it so it may be something on my side.

@awilliansd, since normally application default to the light theme I think we should stick to that.

In my branch, this is the button to choose theme

ErikMogensen · 2026-03-31T06:14:58Z

In my branch, this is the button to choose theme

I pulled ten commits and now I see it. It is quite a different look even for the light theme:

The dark theme:

@paolosalvatori, you are the author - what do you think of it?

awilliansd · 2026-03-31T11:36:22Z

In my branch, this is the button to choose theme

I pulled ten commits and now I see it. It is quite a different look even for the light theme:

The dark theme:

@paolosalvatori, you are the author - what do you think of it?

I tried to get the closest color. But if you want, I can try to get even closer; it's a bit difficult.

awilliansd · 2026-03-31T17:09:13Z

Color changed in Light Theme

Resolve conflicts by prioritizing upstream dashboard and control logic while preserving dark-mode integration in MainForm, HandleQueueControl, and HandleSubscriptionControl.

SeanFeldman · 2026-04-27T19:26:50Z

@awilliansd is the latest round of changes addressing the issue @ErikMogensen brought up?

awilliansd · 2026-04-27T19:32:37Z

@awilliansd is the latest round of changes addressing the issue @ErikMogensen brought up?

Yes, I merged it with the main version, just check my last commits.

0998004

cd66735

Apply dark mode in many files

c6a492c

awilliansd requested review from ErikMogensen, SeanFeldman and paolosalvatori as code owners March 12, 2026 01:21

SeanFeldman requested changes Mar 12, 2026

View reviewed changes

Comment thread src/ServiceBusExplorer/Helpers/ThemeManager.cs Outdated

Comment thread src/ServiceBusExplorer/Helpers/ThemeManager.cs Outdated

awilliansd added 4 commits March 12, 2026 08:38

Add powershell script for dark mode

7bd511b

Translating the script

98a4e8e

Translating theme manager

3678f5a

Dark mode pictures

e24ca43

awilliansd requested a review from SeanFeldman March 16, 2026 00:34

SeanFeldman reviewed Mar 18, 2026

View reviewed changes

Comment thread scripts/build-dark-theme.ps1 Outdated

awilliansd added 2 commits March 18, 2026 08:13

Remove build dark theme script

1304dc3

Change comments

ffc1f15

awilliansd requested a review from SeanFeldman March 18, 2026 11:27

ErikMogensen reviewed Mar 30, 2026

View reviewed changes

awilliansd added 2 commits March 30, 2026 19:46

Fix resource leak in DarkToolStripRenderer

f7df9b4

Fix duplicate event subscriptions in ThemeManager.Apply

d9d3839

awilliansd changed the title ~~Apply dark mode in many files~~ UI Dark mode Mar 30, 2026

awilliansd changed the title ~~UI Dark mode~~ Dark mode UI Mar 30, 2026

awilliansd requested a review from ErikMogensen March 30, 2026 23:26

Align light theme colors with classic Service Bus Explorer palette

6e3a955

awilliansd added 4 commits March 31, 2026 16:23

Improve dark theme tab rendering across the app

4f496dd

Fix dark theme panel and tab rendering inconsistencies

1e9cde2

Refine dark theme colors for panels, tabs, menus, and data grids

53b286b

Refine theme styling for Azure branding, menus, panels, and data grids

e8fdd2f

SeanFeldman mentioned this pull request Apr 13, 2026

Light/Dark theme switching #867

Closed

awilliansd added 2 commits April 19, 2026 14:09

Merge upstream/main into feature/dark-mode

0998004

Resolve conflicts by prioritizing upstream dashboard and control logic while preserving dark-mode integration in MainForm, HandleQueueControl, and HandleSubscriptionControl.

Partial class with single part redudant

cd66735

		MainFormThemeExtension.InitTheme(this, mainMenuStrip);
		ThemeManager.Apply(this);

Conversation

awilliansd commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Dark/Light Theme Toggle

Summary

Changes

New

Updated

Technical Overview

Themes

Notes

Testing

Uh oh!

SeanFeldman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

awilliansd commented Mar 12, 2026

Uh oh!

Uh oh!

SeanFeldman commented Mar 30, 2026

Uh oh!

paolosalvatori commented Mar 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ErikMogensen commented Mar 30, 2026

Uh oh!

awilliansd commented Mar 30, 2026

Uh oh!

ErikMogensen commented Mar 31, 2026

Uh oh!

awilliansd commented Mar 31, 2026

Uh oh!

awilliansd commented Mar 31, 2026

Uh oh!

SeanFeldman commented Apr 27, 2026

Uh oh!

awilliansd commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

awilliansd commented Mar 12, 2026 •

edited

Loading