Fix Pkcs11::new bug preventing PKCS#11 library loading#291
Conversation
…ll-assigned variables; this resolves an issue that prevented my PKCS#11 library from loading Signed-off-by: mematthias <107192630+mematthias@users.noreply.github.com>
Jakuje
left a comment
There was a problem hiding this comment.
Thank you! Looks good to me!
|
When will there be a new version with this fix included? |
First of all, it would be probably better to start a new discussion thread instead of commenting on old issue. Right now, we have the PKCS#11 3.2 in, but I would prefer to get #307 and #306 before the release. After that, I do not think there is anything else blocking the release. |
Sure, will do next time. I didn't want to clutter the issues. |
FWIW I don't mind necro-bumping old threads here since the amount of noise is low anyway. For the record @hug-dev does the releases currently and I hope we'll get one after all these smaller things get merged. |
|
let's necro-bump 🥳 !! Happy to do the release after those PRs! |
This pull request is a small excerpt from the #289 PR.
Summary
This PR fixes a critical issue in
Pkcs11::newthat prevented my PKCS#11 library from being loaded correctly. The root cause was the use ofMaybeUninit::uninit()in a context where zero-initialized ornull-assigned variables were required. This has been resolved by using explicitlynull-assigned variables instead.Changes
Pkcs11::newrelated to improper initialization, resolving library loading failure