Remove ci.sh script to run all from workflow#298
Merged
Conversation
hug-dev
force-pushed
the
remove-ci-script
branch
from
6e931b9 to
93913aa
Compare
The ci.sh script was used in the main script, but only to execute cargo test. It was also used in the nightly workflow but it's not needed since the same steps are run in the merge workflow. Signed-off-by: Hugues de Valon <hugues.de-valon@einride.tech>
hug-dev
force-pushed
the
remove-ci-script
branch
from
93913aa to
1d47788
Compare
Collaborator
|
One thing that the |
Member
Author
|
True but I thought that the "Check for errors" workflow would check it with the |
Collaborator
|
Oh, right. So that should already be covered. Good point! 😅 |
wiktor-k
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ci.sh script was used in the main script, but only to execute cargo test. It was also used in the nightly workflow but it's not needed since the same steps are run in the merge workflow. Also prevents the nightly from failing.