feat(esapi): implement a missing TPM command in command_audit#655
Open
hyperfinitism wants to merge 1 commit into
Open
feat(esapi): implement a missing TPM command in command_audit#655hyperfinitism wants to merge 1 commit into
hyperfinitism wants to merge 1 commit into
Conversation
Added the following wrapper function with its integration test: - set_command_code_audit_status (ESAPI Spec 11.3.50) Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds the missing ESAPI wrapper for Esys_SetCommandCodeAuditStatus to the command_audit TPM command module, along with an integration test to validate the wrapper against GetCapability(AuditCommands).
Changes:
- Implement
Context::set_command_code_audit_status(ESAPI Spec §11.3.50) with proper return-code handling and logging. - Add an integration test that toggles auditing for
CommandCode::GetRandomand verifies the audit command list updates accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tss-esapi/src/context/tpm_commands/command_audit.rs | Adds the ESAPI wrapper method for setting command code audit status. |
| tss-esapi/tests/integration_tests/context_tests/tpm_commands/command_audit_tests.rs | Adds an integration test validating audit status changes via capability queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Copyright 2021 Contributors to the Parsec project. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| mod test_set_command_code_audit_status { | ||
| use crate::common::create_ctx_with_session; |
Member
There was a problem hiding this comment.
Leaving it to you if you want to apply these changes re. the testing.
|
|
||
| #[test] | ||
| fn test_set_command_code_audit_status() { | ||
| let mut context = create_ctx_with_session(); |
ionut-arm
approved these changes
Jul 2, 2026
| // Copyright 2021 Contributors to the Parsec project. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| mod test_set_command_code_audit_status { | ||
| use crate::common::create_ctx_with_session; |
Member
There was a problem hiding this comment.
Leaving it to you if you want to apply these changes re. the testing.
Superhepper
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the following Esys wrapper function with its integration test:
set_command_code_audit_status(ESAPI Spec 11.3.50)Migrated from #625.