Skip to content

refactor: hoist _node_name out of inner loop in get_entity_context (#806) #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhaniiz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor: hoist _node_name out of inner loop in get_entity_context (#806) #809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/app/rag/graph_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ def get_entity_context(
key=lambda neighbor: graph[node_id][neighbor].get("weight", 0),
reverse=True,
)
# Hoisted out of the inner loop to cache the string evaluation
left = _node_name(graph, node_id)

for neighbor_id in neighbors:
edge = graph[node_id][neighbor_id]
left = _node_name(graph, node_id)
right = _node_name(graph, neighbor_id)
key = _relationship_key(left.casefold(), right.casefold())
existing = relationships.setdefault(
Expand Down
Loading