Fix: tolerate CRLF line endings in action-item toggle/count (#21)

Author: parameshjava

src/lib/action-items.test.ts

@@ -46,6 +46,20 @@ describe('toggleCheckboxAt', () => {
     const out = toggleCheckboxAt(src, 99, true)
     expect(out.ok).toBe(false)
   })
+
+  it('handles CRLF line endings and normalizes to LF', () => {
+    const crlf = '- [ ] one\r\n- [x] two\r\n- [ ] three'
+    const out = toggleCheckboxAt(crlf, 0, true)
+    expect(out.ok).toBe(true)
+    if (out.ok) expect(out.value).toBe('- [x] one\n- [x] two\n- [ ] three')
+  })
+
+  it('toggles a middle line in a CRLF document', () => {
+    const crlf = '- [ ] one\r\n- [ ] two\r\n- [ ] three'
+    const out = toggleCheckboxAt(crlf, 1, true)
+    expect(out.ok).toBe(true)
+    if (out.ok) expect(out.value.split('\n')[1]).toBe('- [x] two')
+  })
 })
 
 describe('countActionItems', () => {
@@ -54,6 +68,10 @@ describe('countActionItems', () => {
     expect(countActionItems(src)).toEqual({ done: 2, total: 4 })
   })
 
+  it('counts CRLF documents', () => {
+    expect(countActionItems('- [x] a\r\n- [ ] b\r\n- [x] c')).toEqual({ done: 2, total: 3 })
+  })
+
   it('treats null/empty as zero', () => {
     expect(countActionItems(null)).toEqual({ done: 0, total: 0 })
     expect(countActionItems('')).toEqual({ done: 0, total: 0 })

src/lib/action-items.ts

@@ -1,5 +1,10 @@
 const CHECKBOX_LINE = /^(\s*[-*]\s+)\[( |x|X)\](\s+.*)?$/
 
+// Split on any line ending (LF, CRLF, or lone CR). Matters because a value
+// saved with CRLF would otherwise leave a trailing \r on each line, which the
+// end-anchored CHECKBOX_LINE rejects — making every checkbox un-toggleable.
+const LINE_BREAK = /\r\n|\r|\n/
+
 export type Validated<T> =
   | { ok: true; value: T }
   | { ok: false; error: string }
@@ -10,7 +15,7 @@ export function toggleCheckboxAt(
   checked: boolean,
 ): Validated<string> {
   if (!source) return { ok: false, error: 'No action items' }
-  const lines = source.split('\n')
+  const lines = source.split(LINE_BREAK)
   if (index < 0 || index >= lines.length) {
     return { ok: false, error: 'Line index out of range' }
   }
@@ -39,7 +44,7 @@ export function countActionItems(source: string | null): { done: number; total:
   if (!source) return { done: 0, total: 0 }
   let done = 0
   let total = 0
-  for (const line of source.split('\n')) {
+  for (const line of source.split(LINE_BREAK)) {
     const m = line.match(CHECKBOX_LINE)
     if (!m) continue
     total++

src/lib/actions/meetings.ts

@@ -311,7 +311,9 @@ export async function updateActionItems(
     if (!id) return actionError('Missing meeting id')
 
     const raw = formData.get('action_items_md')
-    const text = raw == null ? '' : String(raw)
+    // Normalize line endings to LF on the way in — a CRLF value (e.g. pasted
+    // text) would otherwise leave a trailing \r that breaks checkbox toggling.
+    const text = (raw == null ? '' : String(raw)).replace(/\r\n?/g, '\n')
     if (text.length > 10_000) return actionError('Action items are too long (max 10000 chars)')
 
     const value = text.trim().length === 0 ? null : text