fix: resolve lint and typecheck issues after merge

- Remove unused variable in shorthand path test
- Add ty: ignore[unknown-argument] for ARE Scenario constructor
  (optional dependency not resolvable by type checker)
- Apply ruff formatting

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: cemde

maseval/interface/environments/are.py

@@ -116,10 +116,7 @@ def setup_state(self, environment_data: Dict[str, Any]) -> Dict[str, Any]:
         scenario = environment_data.get("scenario")
 
         if scenario is None and "apps" not in environment_data:
-            raise ValueError(
-                "environment_data must contain either 'scenario' (ARE Scenario object) "
-                "or 'apps' (list of ARE App instances)."
-            )
+            raise ValueError("environment_data must contain either 'scenario' (ARE Scenario object) or 'apps' (list of ARE App instances).")
 
         if scenario is None:
             scenario = self._build_scenario_from_shorthand(environment_data)
@@ -176,13 +173,13 @@ def _build_scenario_from_shorthand(self, environment_data: Dict[str, Any]) -> An
         time_increment = environment_data.get("time_increment_in_seconds", 1)
 
         scenario = Scenario(
-            scenario_id=environment_data.get("scenario_id", "custom"),
-            apps=apps,
-            events=events,
-            duration=duration,
-            seed=seed,
-            start_time=start_time,
-            time_increment_in_seconds=time_increment,
+            scenario_id=environment_data.get("scenario_id", "custom"),  # ty: ignore[unknown-argument]
+            apps=apps,  # ty: ignore[unknown-argument]
+            events=events,  # ty: ignore[unknown-argument]
+            duration=duration,  # ty: ignore[unknown-argument]
+            seed=seed,  # ty: ignore[unknown-argument]
+            start_time=start_time,  # ty: ignore[unknown-argument]
+            time_increment_in_seconds=time_increment,  # ty: ignore[unknown-argument]
         )
         scenario.initialize()
         return scenario

maseval/interface/environments/are_tool_wrapper.py

@@ -64,10 +64,7 @@ def __init__(self, are_tool: Any, environment: "AREEnvironment"):
 
         # Expose ARE tool metadata via AppToolAdapter (canonical source of truth)
         if AppToolAdapter is None:
-            raise ImportError(
-                "ARE (Agent Research Environments) is required for AREToolWrapper.\n"
-                "Install with: pip install maseval[are]"
-            )
+            raise ImportError("ARE (Agent Research Environments) is required for AREToolWrapper.\nInstall with: pip install maseval[are]")
         adapter = AppToolAdapter(are_tool)
         self.name: str = adapter.name
         self.description: str = adapter.description

tests/interface/environments/test_are_environment.py

@@ -1,7 +1,6 @@
 """Tests for AREEnvironment."""
 
-from unittest.mock import MagicMock, patch, PropertyMock
-import sys
+from unittest.mock import MagicMock, patch
 import pytest
 
 from maseval.interface.environments.are import AREEnvironment
@@ -10,6 +9,7 @@
 @pytest.fixture(autouse=True)
 def mock_app_tool_adapter():
     """Mock AppToolAdapter so AREToolWrapper can initialize without ARE installed."""
+
     def make_adapter(are_tool):
         adapter = MagicMock()
         adapter.name = are_tool.name
@@ -275,12 +275,15 @@ def test_shorthand_passes_config_to_scenario(self, mock_import):
         mock_scenario_instance = _make_mock_scenario()
         mock_scenario_cls.return_value = mock_scenario_instance
 
-        with patch.dict("sys.modules", {
-            "are": MagicMock(),
-            "are.simulation": MagicMock(),
-            "are.simulation.scenarios": MagicMock(),
-            "are.simulation.scenarios.scenario": MagicMock(Scenario=mock_scenario_cls),
-        }):
+        with patch.dict(
+            "sys.modules",
+            {
+                "are": MagicMock(),
+                "are.simulation": MagicMock(),
+                "are.simulation.scenarios": MagicMock(),
+                "are.simulation.scenarios.scenario": MagicMock(Scenario=mock_scenario_cls),
+            },
+        ):
             apps = [MagicMock(), MagicMock()]
             environment_data = {
                 "apps": apps,
@@ -289,7 +292,7 @@ def test_shorthand_passes_config_to_scenario(self, mock_import):
                 "start_time": 100,
                 "time_increment_in_seconds": 5,
             }
-            env = AREEnvironment(environment_data=environment_data)
+            AREEnvironment(environment_data=environment_data)
 
             mock_scenario_cls.assert_called_once()
             call_kwargs = mock_scenario_cls.call_args[1]
@@ -422,6 +425,7 @@ def test_uses_app_tool_adapter_for_metadata(self, mock_adapter_cls):
         mock_env = MagicMock()
 
         from maseval.interface.environments.are_tool_wrapper import AREToolWrapper
+
         wrapper = AREToolWrapper(mock_tool, mock_env)
 
         mock_adapter_cls.assert_called_once_with(mock_tool)

tests/interface/environments/test_are_integration.py

@@ -4,6 +4,7 @@
 
 try:
     import are  # noqa: F401
+
     HAS_ARE = True
 except ImportError:
     HAS_ARE = False
@@ -17,15 +18,18 @@ class TestAREEnvironmentIntegration:
     def test_import_works(self):
         """AREEnvironment can be imported when ARE is installed."""
         from maseval.interface.environments.are import AREEnvironment
+
         assert AREEnvironment is not None
 
     def test_tool_wrapper_import(self):
         """AREToolWrapper can be imported when ARE is installed."""
         from maseval.interface.environments.are_tool_wrapper import AREToolWrapper
+
         assert AREToolWrapper is not None
 
     def test_package_init_exports(self):
         """Package __init__ exports AREEnvironment when ARE is installed."""
         from maseval.interface.environments import AREEnvironment, AREToolWrapper
+
         assert AREEnvironment is not None
         assert AREToolWrapper is not None

tests/interface/environments/test_are_tool_wrapper.py

@@ -9,6 +9,7 @@
 @pytest.fixture(autouse=True)
 def mock_app_tool_adapter():
     """Mock AppToolAdapter so AREToolWrapper can initialize without real ARE validation."""
+
     def make_adapter(are_tool):
         adapter = MagicMock()
         adapter.name = are_tool.name
@@ -25,8 +26,14 @@ def make_adapter(are_tool):
 class TestAREToolWrapper:
     """Tests for AREToolWrapper."""
 
-    def _make_mock_are_tool(self, name="Calendar__create_event", description="Create a calendar event",
-                            inputs=None, output_type="string", return_value="Event created"):
+    def _make_mock_are_tool(
+        self,
+        name="Calendar__create_event",
+        description="Create a calendar event",
+        inputs=None,
+        output_type="string",
+        return_value="Event created",
+    ):
         """Create a mock ARE tool."""
         tool = MagicMock()
         tool.name = name