Skip to content

Commit 1ee08f0

Browse files
committed
Fixed breakage caused by rebase in platform-dock-tab.component.tsx to import TAB_TYPE_WEBVIEW from new location: docking-framework.model.ts
PT-4069: Addressed confusing comments and warning message cause by previous change
1 parent fd9614f commit 1ee08f0

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

extensions/src/platform-scripture-editor/src/main.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,13 +249,13 @@ async function open(
249249
// (one editor slot, no duplicate-(project, readonly) tabs) and the empty-editor probe; see
250250
// resolveOpenEditorDispatch JSDoc for the priority order.
251251
// getAllOpenWebViewDefinitions can time out under load; fall back to an empty list so that
252-
// openResourceViewer still succeeds (opening a new editor tab) rather than throwing.
252+
// open still succeeds (opening a new editor tab) rather than throwing.
253253
let allOpenDefs: SavedWebViewDefinition[] = [];
254254
try {
255255
allOpenDefs = await papi.webViews.getAllOpenWebViewDefinitions();
256256
} catch (e) {
257257
logger.warn(
258-
`openResourceViewer: getAllOpenWebViewDefinitions timed out or failed (${getErrorMessage(e)}); opening as new tab`,
258+
`open: getAllOpenWebViewDefinitions timed out or failed (${getErrorMessage(e)}); opening as new tab`,
259259
);
260260
}
261261
const allScriptureEditors = toScriptureEditorInfos(allOpenDefs);
@@ -352,7 +352,7 @@ async function open(
352352
}
353353
} catch (e) {
354354
logger.warn(
355-
`openResourceViewer: re-check getAllOpenWebViewDefinitions timed out or failed (${getErrorMessage(e)}); using original dispatch`,
355+
`open: re-check getAllOpenWebViewDefinitions timed out or failed (${getErrorMessage(e)}); using original dispatch`,
356356
);
357357
}
358358
}

src/renderer/components/docking/platform-dock-tab.component.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { TabInfo } from '@shared/models/docking-framework.model';
2-
import { TAB_TYPE_WEBVIEW } from '@renderer/components/web-view.component';
1+
import { TabInfo, TAB_TYPE_WEBVIEW } from '@shared/models/docking-framework.model';
32

43
import { TAB_GROUP } from './platform-dock-layout-positioning.util';
54
import { PlatformPanel } from './platform-panel.component';

0 commit comments

Comments
 (0)