Commit 431d7b6
markers-checklist follow-up: TJ review polish + ScriptureRange contract fix
- ChecklistService: honor platform ScriptureRange contract — End == null now
narrows to a single-verse range at Start (was: scan to last verse of project).
No production caller triggers the changed branch; new regression test
BuildChecklistData_VerseRangeEndOmitted_ScansSingleVerseAtStart covers it.
- platform-scripture.d.ts: tighten verseRange.end TSDoc to reference the
canonical ScriptureRange semantics; document '' fallback on
ResolvedComparativeTexts.texts[].name / fullName when available is false.
- LinkedScrRefButton: mirror the @experimental marker on the function itself
so IDE / TypeDoc surfaces the warning at every call site (was: only on
LinkedScrRefButtonProps).
- popover.tsx (PopoverPortalContainerProvider): rephrase JSDoc so the inline
useState<HTMLElement | null>(null) reference lands mid-line and isn't
reflowed across paragraphs by Prettier.
- Rename test ResolveComparativeTexts_MixedResolutionPaths_… →
ResolveComparativeTexts_MixedAvailability_… (only one resolution path remains
after name-fallback was removed).
- Regenerate lib/platform-bible-react/dist for the JSDoc / @experimental
changes. Includes benign CSS reordering churn (build-tool non-determinism).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 53580a9 commit 431d7b6
11 files changed
Lines changed: 115 additions & 41 deletions
File tree
- c-sharp-tests/Checklists
- c-sharp/Checklists
- extensions/src/platform-scripture/src/types
- lib/platform-bible-react
- dist
- src/components
- basics
- shadcn-ui
Lines changed: 59 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
542 | 542 | | |
543 | 543 | | |
544 | 544 | | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
545 | 604 | | |
546 | 605 | | |
547 | 606 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
327 | 327 | | |
328 | 328 | | |
329 | 329 | | |
330 | | - | |
331 | | - | |
332 | | - | |
333 | | - | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
334 | 337 | | |
335 | 338 | | |
336 | 339 | | |
| |||
353 | 356 | | |
354 | 357 | | |
355 | 358 | | |
356 | | - | |
357 | | - | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
358 | 368 | | |
359 | 369 | | |
360 | 370 | | |
| |||
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1661 | 1661 | | |
1662 | 1662 | | |
1663 | 1663 | | |
1664 | | - | |
| 1664 | + | |
| 1665 | + | |
1665 | 1666 | | |
1666 | 1667 | | |
1667 | 1668 | | |
| |||
1732 | 1733 | | |
1733 | 1734 | | |
1734 | 1735 | | |
1735 | | - | |
| 1736 | + | |
1736 | 1737 | | |
1737 | | - | |
| 1738 | + | |
1738 | 1739 | | |
1739 | 1740 | | |
1740 | 1741 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4448 | 4448 | | |
4449 | 4449 | | |
4450 | 4450 | | |
4451 | | - | |
4452 | | - | |
4453 | | - | |
4454 | | - | |
4455 | | - | |
4456 | | - | |
4457 | | - | |
4458 | 4451 | | |
4459 | 4452 | | |
4460 | 4453 | | |
| |||
4474 | 4467 | | |
4475 | 4468 | | |
4476 | 4469 | | |
| 4470 | + | |
| 4471 | + | |
| 4472 | + | |
| 4473 | + | |
| 4474 | + | |
| 4475 | + | |
| 4476 | + | |
4477 | 4477 | | |
4478 | 4478 | | |
4479 | 4479 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2080 | 2080 | | |
2081 | 2081 | | |
2082 | 2082 | | |
| 2083 | + | |
| 2084 | + | |
| 2085 | + | |
| 2086 | + | |
2083 | 2087 | | |
2084 | 2088 | | |
2085 | 2089 | | |
| |||
2678 | 2682 | | |
2679 | 2683 | | |
2680 | 2684 | | |
2681 | | - | |
2682 | | - | |
2683 | | - | |
2684 | | - | |
2685 | | - | |
2686 | | - | |
2687 | | - | |
| 2685 | + | |
| 2686 | + | |
| 2687 | + | |
| 2688 | + | |
| 2689 | + | |
2688 | 2690 | | |
2689 | 2691 | | |
2690 | 2692 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| |||
0 commit comments