remove unused select books dialog

Author: Sebastian-ubs

assets/localization/en.json

@@ -316,7 +316,6 @@
   "%scrollGroup_3%": "D",
   "%scrollGroup_4%": "E",
   "%scrollGroup_undefined%": "Ø",
-  "%selectBooks_title_selectBooks%": "Select Books",
   "%selectMultipleProjects_title_selectProjects%": "Select Projects",
   "%selectProject_title%": "Select Project",
   "%settings_defaultMessage_loadingOneSetting%": "Loading setting",

assets/localization/es.json

@@ -436,7 +436,6 @@
   "%scrollGroup_3%": "D",
   "%scrollGroup_4%": "E",
   "%scrollGroup_undefined%": "Ø",
-  "%selectBooks_title_selectBooks%": "Seleccionar libros",
   "%selectMultipleProjects_title_selectProjects%": "Seleccionar Proyectos",
   "%selectProject_title%": "Seleccionar Proyecto",
   "%settings_defaultMessage_loadingOneSetting%": "Cargando configuración",

e2e-tests/tests/isolated/overlay/dialog-rendering.spec.ts

@@ -435,62 +435,4 @@ test('all dialog types render correctly in modal and non-modal form', async ({ m
     // eslint-disable-next-line no-type-assertion/no-type-assertion
     expect((result as string[]).length).toBeGreaterThanOrEqual(1);
   });
-
-  // =========================================================================
-  // Select Books Dialog
-  // =========================================================================
-
-  await test.step('select books dialog - modal', async () => {
-    const resultPromise = showDialogViaWebSocket<string[]>('platform.selectBooks', {
-      title: 'Pick Books',
-      prompt: 'Select some books',
-      selectedBookIds: ['GEN', 'EXO'],
-      isModal: true,
-    });
-
-    const dialog = modalDialog(mainPage);
-    await expect(dialog).toBeVisible({ timeout: 10_000 });
-    await expect(modalBackdrop(mainPage)).toBeVisible();
-    await expect(dialog).toContainText('Select some books');
-
-    // Verify book checklist renders (Genesis and Exodus should be pre-selected)
-    await expect(dialog.getByText('Genesis')).toBeVisible({ timeout: 5_000 });
-    await expect(dialog.getByText('Exodus')).toBeVisible();
-
-    // Submit with pre-selected books using the dialog's specific submit button class.
-    // Fixed modal + overflow can clip the footer; scrollIntoView does not fix that, and Playwright's
-    // click can fail even with force:true when the hit point is outside the viewport.
-    const submitButton = dialog.locator('.select-books-dialog-submit-button');
-    await submitButton.evaluate((el) => {
-      if (el instanceof HTMLElement) el.click();
-    });
-
-    await expect(dialog).not.toBeVisible({ timeout: 3_000 });
-    const result = await resultPromise;
-    expect(Array.isArray(result)).toBe(true);
-    expect(result).toContain('GEN');
-    expect(result).toContain('EXO');
-  });
-
-  await test.step('select books dialog - non-modal (floating tab)', async () => {
-    const resultPromise = showDialogViaWebSocket<string[]>('platform.selectBooks', {
-      prompt: 'Books from tab',
-      selectedBookIds: ['MAT'],
-    });
-
-    const panel = mainPage.locator('.dock-panel').filter({ hasText: 'Books from tab' });
-    await expect(panel).toBeVisible({ timeout: 10_000 });
-    await expect(modalDialog(mainPage)).not.toBeVisible();
-
-    // Verify checklist renders
-    await expect(panel.getByText('Matthew')).toBeVisible({ timeout: 5_000 });
-
-    const submitButton = panel.locator('.select-books-dialog-submit-button');
-    await submitButton.click();
-
-    await expect(panel).not.toBeVisible({ timeout: 3_000 });
-    const result = await resultPromise;
-    expect(Array.isArray(result)).toBe(true);
-    expect(result).toContain('MAT');
-  });
 });

src/renderer/components/dialogs/dialog-definition.model.ts

@@ -10,8 +10,6 @@ export const ABOUT_DIALOG_TYPE = 'platform.aboutDialog';
 export const SELECT_PROJECT_DIALOG_TYPE = 'platform.selectProject';
 /** The tabType for the select multiple projects dialog in `select-multiple-projects.dialog.tsx` */
 export const SELECT_MULTIPLE_PROJECTS_DIALOG_TYPE = 'platform.selectMultipleProjects';
-/** The tabType for the select books dialog in `select-books.dialog.tsx` */
-export const SELECT_BOOKS_DIALOG_TYPE = 'platform.selectBooks';
 /** The dialogType for alert dialogs rendered via overlay */
 export const ALERT_DIALOG_TYPE = 'platform.alert';
 /** The dialogType for confirm dialogs rendered via overlay */
@@ -28,12 +26,6 @@ export type SelectMultipleProjectsDialogOptions = ProjectDialogOptionsBase & {
   selectedProjectIds?: string[];
 };
 
-/** Options to provide when showing the Select Books dialog */
-export type SelectBooksDialogOptions = DialogOptions & {
-  /** Books IDs that should start selected in the dialog */
-  selectedBookIds?: string[];
-};
-
 /** Options to provide when showing an alert dialog */
 export type AlertDialogOptions = DialogOptions & {
   /** The message body displayed in the dialog. Required for alert dialogs. */
@@ -66,7 +58,6 @@ export interface DialogTypes {
     SelectMultipleProjectsDialogOptions,
     string[]
   >;
-  [SELECT_BOOKS_DIALOG_TYPE]: DialogDataTypes<SelectBooksDialogOptions, string[]>;
   [ALERT_DIALOG_TYPE]: DialogDataTypes<AlertDialogOptions, true>;
   [CONFIRM_DIALOG_TYPE]: DialogDataTypes<ConfirmDialogOptions, boolean>;
 }

src/renderer/components/dialogs/index.ts

@@ -4,7 +4,6 @@ import { CONFIRM_DIALOG } from './confirm-dialog.component';
 import { SELECT_MULTIPLE_PROJECTS_DIALOG } from './select-multiple-projects.dialog';
 import { SELECT_PROJECT_DIALOG } from './select-project.dialog';
 import { DialogDefinition, DialogTabTypes } from './dialog-definition.model';
-import { SELECT_BOOKS_DIALOG } from './select-books-dialog.component';
 
 /**
  * Map of all available dialog definitions used to create dialogs
@@ -17,7 +16,6 @@ export const DIALOGS: { [DialogTabType in DialogTabTypes]: DialogDefinition<Dial
   [CONFIRM_DIALOG.tabType]: CONFIRM_DIALOG,
   [SELECT_PROJECT_DIALOG.tabType]: SELECT_PROJECT_DIALOG,
   [SELECT_MULTIPLE_PROJECTS_DIALOG.tabType]: SELECT_MULTIPLE_PROJECTS_DIALOG,
-  [SELECT_BOOKS_DIALOG.tabType]: SELECT_BOOKS_DIALOG,
 };
 
 /** All tab types for available dialogs */

src/renderer/components/dialogs/select-books-dialog.component.scss

@@ -49,7 +49,6 @@ const mockDialogs = {
     tabType: 'platform.selectMultipleProjects',
     Component: vi.fn(),
   },
-  'platform.selectBooks': { tabType: 'platform.selectBooks', Component: vi.fn() },
   'platform.alert': {
     tabType: 'platform.alert',
     dialogRole: 'alertdialog',