Skip to content

checklist > checkbox group#2267

Merged
Sebastian-ubs merged 1 commit into
mainfrom
rename-shared-checklist-component
Jun 9, 2026
Merged

checklist > checkbox group#2267
Sebastian-ubs merged 1 commit into
mainfrom
rename-shared-checklist-component

Conversation

@Sebastian-ubs

@Sebastian-ubs Sebastian-ubs commented May 13, 2026

Copy link
Copy Markdown
Contributor

Rename checklist component to checkbox group to avoid confusion with the checklist feature of Paratext.

  • Deprecate name of checklist component
  • Align naming checkbox group with shadcn

This change is Reviewable

@tjcouch-sil tjcouch-sil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjcouch-sil reviewed 1 file and made 1 comment.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).


lib/platform-bible-react/src/components/basics/checkbox-list.component.tsx line 42 at r1 (raw file):

/** Renders a list of checkboxes. Each checkbox corresponds to an item from the `listItems` array. */
export function CheckboxList({

Unfortunately we can't just rely on not knowing of extensions that use it in my opinion. This is such a generic component and was created so long ago (2 years) that it's really hard to know if it actually isn't used anywhere in the world. I suggest you re-export this and the props as the original names with deprecated statements in their TSDocs so we don't duplicate the code but we're still notifying that we want to get rid of the old component. Something like one of these solutions will hopefully let you add different TSDocs.

@tjcouch-sil tjcouch-sil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjcouch-sil partially reviewed 1 file.
Reviewable status: 2 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).

@tjcouch-sil tjcouch-sil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjcouch-sil reviewed 1 file.
Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).

@Sebastian-ubs

Copy link
Copy Markdown
Contributor Author

Instead we should use Checkbox group https://ui.shadcn.com/docs/components/radix/checkbox#group

@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch from ce1e5ec to 7ff2f30 Compare May 22, 2026 17:43
@Sebastian-ubs
Sebastian-ubs enabled auto-merge (squash) May 22, 2026 17:44
@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch from 7ff2f30 to 685ac46 Compare May 22, 2026 17:49
@Sebastian-ubs

Copy link
Copy Markdown
Contributor Author

Rebased onto latest main and addressed review feedback:

  • Renamed the shared component to CheckboxGroup (file, props, stories, exports, and the select-books-dialog consumer).
  • Per @tjcouch-sil's feedback, kept Checklist and ChecklistProps as @deprecated backward-compatible re-exports (aliasing CheckboxGroup/CheckboxGroupProps) so existing external consumers keep working while signaling the migration.
  • Fixed outdated Tailwind tw-tw: prefixes in the stories (non-functional under Tailwind 4) and rebuilt the platform-bible-react dist bundle.

Note: branch was force-pushed (rebased onto current main, dropping the redundant shadcn-upgrade commit already in main as #2207). Ready for another look. 🙏

@Sebastian-ubs
Sebastian-ubs requested a review from tjcouch-sil May 22, 2026 17:49
@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch 2 times, most recently from 4b3daa2 to ba52f9f Compare May 22, 2026 17:54
@Sebastian-ubs

Copy link
Copy Markdown
Contributor Author

sorry, was trying to add the icon to the title like in #2267 but that's not needed. so ready for review now

@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch 2 times, most recently from 5522ca4 to f70e438 Compare June 5, 2026 17:34
@Sebastian-ubs

Copy link
Copy Markdown
Contributor Author

now really ready for human review

@tjcouch-sil tjcouch-sil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the updates. Just one last thing to look at

@tjcouch-sil partially reviewed 10 files and all commit messages, made 3 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).


lib/platform-bible-react/src/components/basics/checkbox-list.component.tsx line 42 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Unfortunately we can't just rely on not knowing of extensions that use it in my opinion. This is such a generic component and was created so long ago (2 years) that it's really hard to know if it actually isn't used anywhere in the world. I suggest you re-export this and the props as the original names with deprecated statements in their TSDocs so we don't duplicate the code but we're still notifying that we want to get rid of the old component. Something like one of these solutions will hopefully let you add different TSDocs.

Thanks!


lib/platform-bible-react/src/index.ts line 167 at r6 (raw file):

export type { ChapterRangeSelectorProps } from './components/basics/chapter-range-selector.component';
export {
  /** @deprecated Use {@link CheckboxGroup} instead. */

Please put the date of deprecation here and in the checkbox group file

@Sebastian-ubs Sebastian-ubs changed the title checklist > checkbox list checklist > checkbox group Jun 6, 2026
@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch from f70e438 to 7958e61 Compare June 8, 2026 15:36

@tjcouch-sil tjcouch-sil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks!

Renames the platform-bible-react basics component (and its props,
stories, and exports) from Checklist to CheckboxGroup, and updates the
select-books-dialog consumer.

Per review feedback, keeps Checklist and ChecklistProps as @deprecated
backward-compatible aliases so existing external consumers continue to
work while signaling the move to CheckboxGroup. Rebuilt the library dist
bundle.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@Sebastian-ubs
Sebastian-ubs force-pushed the rename-shared-checklist-component branch from 7958e61 to 8c124db Compare June 9, 2026 13:34
@Sebastian-ubs
Sebastian-ubs requested a review from tjcouch-sil June 9, 2026 13:34

@Sebastian-ubs Sebastian-ubs left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sebastian-ubs made 1 comment.
Reviewable status: 3 of 10 files reviewed, 1 unresolved discussion (waiting on tjcouch-sil).


lib/platform-bible-react/src/index.ts line 167 at r6 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Please put the date of deprecation here and in the checkbox group file

Done.

@Sebastian-ubs
Sebastian-ubs merged commit f6513fa into main Jun 9, 2026
6 of 10 checks passed
@Sebastian-ubs
Sebastian-ubs deleted the rename-shared-checklist-component branch June 9, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants