checklist > checkbox group#2267
Conversation
tjcouch-sil
left a comment
There was a problem hiding this comment.
@tjcouch-sil reviewed 1 file and made 1 comment.
Reviewable status: 1 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).
lib/platform-bible-react/src/components/basics/checkbox-list.component.tsx line 42 at r1 (raw file):
/** Renders a list of checkboxes. Each checkbox corresponds to an item from the `listItems` array. */ export function CheckboxList({
Unfortunately we can't just rely on not knowing of extensions that use it in my opinion. This is such a generic component and was created so long ago (2 years) that it's really hard to know if it actually isn't used anywhere in the world. I suggest you re-export this and the props as the original names with deprecated statements in their TSDocs so we don't duplicate the code but we're still notifying that we want to get rid of the old component. Something like one of these solutions will hopefully let you add different TSDocs.
tjcouch-sil
left a comment
There was a problem hiding this comment.
@tjcouch-sil partially reviewed 1 file.
Reviewable status: 2 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).
tjcouch-sil
left a comment
There was a problem hiding this comment.
@tjcouch-sil reviewed 1 file.
Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).
e47eff3 to
ce1e5ec
Compare
|
Instead we should use Checkbox group https://ui.shadcn.com/docs/components/radix/checkbox#group |
ce1e5ec to
7ff2f30
Compare
7ff2f30 to
685ac46
Compare
|
Rebased onto latest
Note: branch was force-pushed (rebased onto current main, dropping the redundant shadcn-upgrade commit already in main as #2207). Ready for another look. 🙏 |
4b3daa2 to
ba52f9f
Compare
|
sorry, was trying to add the icon to the title like in #2267 but that's not needed. so ready for review now |
5522ca4 to
f70e438
Compare
|
now really ready for human review |
tjcouch-sil
left a comment
There was a problem hiding this comment.
Nice! Thanks for the updates. Just one last thing to look at
@tjcouch-sil partially reviewed 10 files and all commit messages, made 3 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Sebastian-ubs).
lib/platform-bible-react/src/components/basics/checkbox-list.component.tsx line 42 at r1 (raw file):
Previously, tjcouch-sil (TJ Couch) wrote…
Unfortunately we can't just rely on not knowing of extensions that use it in my opinion. This is such a generic component and was created so long ago (2 years) that it's really hard to know if it actually isn't used anywhere in the world. I suggest you re-export this and the props as the original names with deprecated statements in their TSDocs so we don't duplicate the code but we're still notifying that we want to get rid of the old component. Something like one of these solutions will hopefully let you add different TSDocs.
Thanks!
lib/platform-bible-react/src/index.ts line 167 at r6 (raw file):
export type { ChapterRangeSelectorProps } from './components/basics/chapter-range-selector.component'; export { /** @deprecated Use {@link CheckboxGroup} instead. */
Please put the date of deprecation here and in the checkbox group file
f70e438 to
7958e61
Compare
Renames the platform-bible-react basics component (and its props, stories, and exports) from Checklist to CheckboxGroup, and updates the select-books-dialog consumer. Per review feedback, keeps Checklist and ChecklistProps as @deprecated backward-compatible aliases so existing external consumers continue to work while signaling the move to CheckboxGroup. Rebuilt the library dist bundle. Co-Authored-By: Claude Code <noreply@anthropic.com>
7958e61 to
8c124db
Compare
Sebastian-ubs
left a comment
There was a problem hiding this comment.
@Sebastian-ubs made 1 comment.
Reviewable status: 3 of 10 files reviewed, 1 unresolved discussion (waiting on tjcouch-sil).
lib/platform-bible-react/src/index.ts line 167 at r6 (raw file):
Previously, tjcouch-sil (TJ Couch) wrote…
Please put the date of deprecation here and in the checkbox group file
Done.
Rename checklist component to checkbox group to avoid confusion with the checklist feature of Paratext.
This change is