docs: critique proto/saroj-studies orchestration prompt + revised v2#2273
Open
merchako wants to merge 3 commits into
Open
docs: critique proto/saroj-studies orchestration prompt + revised v2#2273merchako wants to merge 3 commits into
merchako wants to merge 3 commits into
Conversation
Pre-flight review of the draft orchestration prompt against the actual state of paranext-core and the PRD. Identifies critical inconsistencies (wrong package path, made-up data shape, conflict with PRD's "consistency over novelty" guidance, picker already exists on pt-3976-shared-resource- picker-ui) and provides a paste-ready revised prompt that addresses them. https://claude.ai/code/session_01FN5PduQzmUwiTD28mytLpN
CI's "check JS/TS formatting" step runs `prettier --check` repo-wide and flagged the markdown file for table column alignment and `*em*` → `_em_` normalization. No content changes. https://claude.ai/code/session_01FN5PduQzmUwiTD28mytLpN
Per UX-designer feedback: - C4: The PT-3976 picker is a dev's in-progress PR, not from UX. Restore "3 picker variants per area" in Agent A (single-select) and Agent B (multi-select). The "be consistent with project selection UI" guidance in PRD Rabbit Hole #3 applies to the later convergence step, not this ideation pass. - C6: Stub utilities (like filterResourcesByUserLanguages) are fine as long as they ship with a sample-data-backed implementation in <name>.utils.ts. They communicate intent in the story; final API will be settled later. Also adjust setup so the integration branch lives in its own worktree (preserving the orchestrator's branch state) and the orchestration docs are bundled into proto/saroj-studies so every worktree has them. https://claude.ai/code/session_01FN5PduQzmUwiTD28mytLpN
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-flight review of the draft
proto/saroj-studiesorchestration prompt against the actual state ofparanext-coreand the PRD, plus a paste-ready revised v2 prompt that addresses every Critical-tier issue.Adds two docs under
docs/plans/:saroj-studies-orchestration-critique.md— severity-tiered critique (Critical / Important / Minor) and open questionssaroj-studies-orchestration-prompt-v2.md— revised orchestration prompt, ready to paste into Claude CodeCritical issues flagged
packages/platform-bible-react→lib/platform-bible-react)id,title,isDownloaded,addedBy, …) vs realDblResourceDatafromplatform-bible-utilspt-3976-shared-resource-picker-ui— re-inventing it conflicts with the PRD's "consistency over novelty" guidance (Rabbit Hole Configure publishing to GH #3)filterResourcesByUserLanguagesdoesn't exist; PRD never mentions user-language filteringtw-prefix not honored by the inline-styleWorkspaceShellTask→Agent); cwd doesn't propagate to subagentsTest plan
proto/saroj-studiesGenerated by Claude Code
This change is