Skip to content

Hide scroll group selector for 'simple'#2280

Draft
imnasnainaec wants to merge 2 commits into
mainfrom
platform-scripture-editor-simple-no-scroll-group-selector
Draft

Hide scroll group selector for 'simple'#2280
imnasnainaec wants to merge 2 commits into
mainfrom
platform-scripture-editor-simple-no-scroll-group-selector

Conversation

@imnasnainaec
Copy link
Copy Markdown
Contributor

@imnasnainaec imnasnainaec commented May 15, 2026

Part 2 of #2249, which has the following commit comment:

Navigation is now exclusively through the main app toolbar. The editor already synced with the main toolbar via scroll group 0; this removes the redundant in-editor BookChapterControl and ScrollGroupSelector

Keeping this in draft because there is a bug in 'simple' mode without the controls:

  • Platform Scripture Editor doesn't stay synced with the top-bar control if they are on different scroll groups. That was already an issue, but is made harder to diagnose if this pr removes the scroll group selector.

The second commit of this pr is one proposed solution: adding a listener to the local storage to see when the scroll group changes.

Another possible approach would be to refactor useWebViewScrollGroupScrRef to (e.g.) have two different versions of scrRef and setScrRefWithScroll, one that tracks with the global scroll group (for simple) and one that doesn't (for power).


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant