You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Devin claims (https://app.devin.ai/review/paranext/paranext-core/pull/2365) this pr introduces "an oscillation between fetchResources = true/false" that potentially "re-triggers the install on every cycle". In the "Prompt for agents", it suggests two different ways to fix it.
(Devin also notes that same issue is already present in extensions/src/platform-scripture-editor/src/model-text-panel.web-view.tsx, so a fix could be applied there too.)
The old code attempted one install and stopped. The new code creates an unbounded retry loop that consumes network bandwidth and CPU on persistent failures.
Of the two original fix suggestions, I'm personally partial to adding a ref to keep it out of the useEffect dependencies. Something like
Oh yikes. Sorry I need to think through this more...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed two bugs with the new cached resources implementation
This change is