Skip to content

docs: design plan for immediate-apply Internet Settings with deferred restart#2491

Open
merchako wants to merge 3 commits into
mainfrom
claude/unrestricted-internet-restart-9e59zr
Open

docs: design plan for immediate-apply Internet Settings with deferred restart#2491
merchako wants to merge 3 commits into
mainfrom
claude/unrestricted-internet-restart-9e59zr

Conversation

@merchako

@merchako merchako commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a design proposal (docs/specs/2026-07-02-internet-settings-restart-ux-design.md) for reworking the Internet Settings dialog in the paratext-registration extension.

Today the dialog bundles internet-use mode, proxy config, and server selection behind a single "Save and restart" button that always restarts the app. This violates Platform.Bible's immediate-apply principle and forces a restart even when the changed setting may not need one.

The proposal recommends:

  1. Immediate apply — each setting persists as the user changes it; remove the mandatory save button. (The C# setter already mutates ParatextData's InternetAccess state live, so this is a frontend change.)
  2. Per-setting restart tagging — classify each setting as live vs restart-required, so a restart is only prompted when actually needed.
  3. Restart now / Restart later — replace the forced restart with a choice, letting users batch several restart-requiring changes into one restart.
  4. Don't strand novices after dismissal — a dismissed prompt keeps a persistent reminder banner until an actual restart, and the prompt is also surfaced in the empty (no-project) state, which is where a first-time user is most likely to configure these settings.

Notes

  • Docs-only change; no code or behavior changes in this PR.
  • The design flags one open question that needs empirical verification before build: whether ParatextData picks up a live internet-use change without a restart (in-repo evidence at PlatformScrTextCollection.cs:47 is suggestive but the networking consumers live in ParatextData.dll).

AI-assisted — session

🤖 Generated with Claude Code


Generated by Claude Code


This change is Reviewable

claude added 3 commits July 2, 2026 01:34
… restart

Proposes moving the Internet Settings dialog from a mandatory
"Save and restart" button to immediate-apply per setting, tagging
restart-requiring settings, and offering a Restart now / Restart later
choice with a persistent reminder (including in the empty-state UI) so
users are not stranded after dismissing the prompt.

Co-authored-by: Claude <noreply@anthropic.com>
Session-URL: https://claude.ai/code/session_018JRuUNqsC5vnCZAXYyZ1SG
Fixes the format:check CI failure (emphasis markers and table padding).

Co-authored-by: Claude <noreply@anthropic.com>
Session-URL: https://claude.ai/code/session_018JRuUNqsC5vnCZAXYyZ1SG
Wires in the Applying Changes, Triggers and Actions, Settings & State,
and Dismissal Patterns guideline articles as relative links to their
eventual merged paths, plus a References section noting each is pending
on an open PR.

Co-authored-by: Claude <noreply@anthropic.com>
Session-URL: https://claude.ai/code/session_018JRuUNqsC5vnCZAXYyZ1SG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants