Skip to content

Forward colors option to PHPUnit, even when it matches the default option value. #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mickverm wants to merge 1 commit into
base: 7.x
Choose a base branch
from
+1 −9
Draft

Forward colors option to PHPUnit, even when it matches the default option value. #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/Options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,13 +191,6 @@ public static function fromConsoleInput(InputInterface $input, string $cwd): sel
$functional = $options['functional'];
unset($options['functional']);

assert(array_key_exists('colors', $options));
if ($options['colors'] === Configuration::COLOR_DEFAULT) {
Copy link
Copy Markdown
Author

@mickverm mickverm Apr 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered that when I simply removed the 'if', the option fell back to the default nonetheless (when not passed as an argument) because of what was on line 700. Which meant it fell back to --colors=never, which would override the colors="true" configured in phpunit.dist.xml.

unset($options['colors']);
} elseif ($options['colors'] === null) {
$options['colors'] = Configuration::COLOR_AUTO;
}

assert(array_key_exists('coverage-text', $options));
if ($options['coverage-text'] === null) {
$options['coverage-text'] = 'php://stdout';
Expand Down Expand Up @@ -695,9 +688,8 @@ public static function setInputDefinition(InputDefinition $inputDefinition): voi
new InputOption(
'colors',
null,
InputOption::VALUE_OPTIONAL,
InputOption::VALUE_REQUIRED,
'@see PHPUnit guide, chapter: ' . $chapter = 'Reporting',
Configuration::COLOR_DEFAULT,
),
new InputOption(
'no-progress',
Expand Down