Replace inline USDT implementation with github.com/parca-dev/usdt

- pfelf.USDTProbe is now a type alias for usdt.Probe
- pfelf.ParseUSDTProbes() delegates to usdt.ParseProbes() via adapter
- pfelf.ParseUSDTArguments/USDTSpecToBytes delegate to usdt package
- pfelfELFReader adapter implements usdt.ELFReader interface
- All consumers (interpreter, processmanager, gpu, coredump) continue
  working transparently via the type alias

Author: gnurizen

LICENSES/github.com/parca-dev/usdt/LICENSE

@@ -0,0 +1,199 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (which shall not include combinations of the Work with other works).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based upon (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and derivative works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control
+      systems, and issue tracking systems that are managed by, or on behalf
+      of, the Licensor for the purpose of discussing and improving the Work,
+      but excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to use, reproduce, modify, distribute, prepare
+      Derivative Works of, and publicly display the Work and such Derivative
+      Works in all media and formats whether now known or hereafter devised.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright notice to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Support. You are not required to accept
+      warranty or support for the Work from any Contributor. However,
+      you may choose to offer and charge a fee for warranty, support,
+      indemnity or other liability obligations consistent with this
+      License. When accepting any such obligations on your own behalf
+      or on behalf of another Contributor, you must obtain the
+      Contributor's express prior written consent and acknowledge
+      that the Contributor may be liable to You for any damages
+      incurred by You as a result of accepting such warranty or support.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. Don't include
+      the brackets!  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "license" line as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

go.mod

@@ -25,6 +25,7 @@ require (
 	github.com/minio/sha256-simd v1.0.1
 	github.com/open-telemetry/sig-profiling/tools/profcheck v0.0.0-20260303084341-52f633d434c9
 	github.com/parca-dev/oomprof v0.1.6
+	github.com/parca-dev/usdt v0.0.2
 	github.com/peterbourgon/ff/v3 v3.4.0
 	github.com/sirupsen/logrus v1.9.4
 	github.com/stretchr/testify v1.11.1

go.sum

@@ -196,6 +196,8 @@ github.com/opencontainers/runtime-spec v1.2.0 h1:z97+pHb3uELt/yiAWD691HNHQIF07bE
 github.com/opencontainers/runtime-spec v1.2.0/go.mod h1:jwyrGlmzljRJv/Fgzds9SsS/C5hL+LL3ko9hs6T5lQ0=
 github.com/parca-dev/oomprof v0.1.6 h1:potfd09aphNKqsIF54ZsiddTvksVMjQiaKnczFOsVGM=
 github.com/parca-dev/oomprof v0.1.6/go.mod h1:iqI6XrmiNWOa8m2vEIKo+GtQrqbWCMLFpBWuk8RuAPs=
+github.com/parca-dev/usdt v0.0.2 h1:bpKQycQ++zV8pwkMaJSxZS07XnEXqO3rkHcLYFJDTl4=
+github.com/parca-dev/usdt v0.0.2/go.mod h1:bjh3OTksk+pyP7WsHWlRKWaMSJTUr0gx0piZ/tAv6/w=
 github.com/peterbourgon/ff/v3 v3.4.0 h1:QBvM/rizZM1cB0p0lGMdmR7HxZeI/ZrBWB4DqLkMUBc=
 github.com/peterbourgon/ff/v3 v3.4.0/go.mod h1:zjJVUhx+twciwfDl0zBcFzl4dW8axCRyXE/eKY9RztQ=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=

libpf/pfelf/usdt.go

@@ -4,139 +4,57 @@
 package pfelf // import "go.opentelemetry.io/ebpf-profiler/libpf/pfelf"
 
 import (
-	"encoding/binary"
-	"strings"
-)
-
-// USDTProbe represents a USDT probe found in ELF with file-offset-adjusted addresses
-type USDTProbe struct {
-	Provider        string
-	Name            string
-	Location        uint64 // File offset for uprobe attachment
-	Base            uint64 // Original base address from note
-	SemaphoreOffset uint64 // File offset for semaphore
-	Arguments       string
-}
+	"debug/elf"
 
-// ParseUSDTProbes reads USDT probe information from ELF .note.stapsdt section.
-// It applies prelink adjustments if .stapsdt.base section exists, and converts
-// virtual addresses to file offsets suitable for uprobe attachment.
-func (f *File) ParseUSDTProbes() ([]USDTProbe, error) {
-	// LoadSections populates f.Sections from section headers.
-	// It is idempotent and required for the .note.stapsdt lookup below.
-	if err := f.LoadSections(); err != nil {
-		return nil, err
-	}
+	"github.com/parca-dev/usdt"
+)
 
-	var probes []USDTProbe
+// USDTProbe is an alias for usdt.Probe for backwards compatibility.
+type USDTProbe = usdt.Probe
 
-	// Find .note.stapsdt section
-	var stapsdt *Section
-	for i := range f.Sections {
-		if f.Sections[i].Name == ".note.stapsdt" {
-			stapsdt = &f.Sections[i]
-			break
-		}
-	}
-	if stapsdt == nil {
-		return nil, nil // No USDT probes in this binary
-	}
+// pfelfELFReader adapts pfelf.File to the usdt.ELFReader interface.
+type pfelfELFReader struct {
+	f *File
+}
 
-	data, err := stapsdt.Data(16 * 1024)
-	if err != nil {
+func (r *pfelfELFReader) Sections() ([]usdt.ELFSection, error) {
+	if err := r.f.LoadSections(); err != nil {
 		return nil, err
 	}
-
-	// Find .stapsdt.base section address for prelink adjustment
-	var baseAddr uint64
-	for i := range f.Sections {
-		if f.Sections[i].Name == ".stapsdt.base" {
-			baseAddr = f.Sections[i].Addr
-			break
-		}
-	}
-
-	// Parse note entries
-	offset := 0
-	for offset < len(data) {
-		if offset+12 > len(data) {
-			break
-		}
-
-		// Note header: namesz(4) + descsz(4) + type(4)
-		namesz := binary.LittleEndian.Uint32(data[offset : offset+4])
-		descsz := binary.LittleEndian.Uint32(data[offset+4 : offset+8])
-		noteType := binary.LittleEndian.Uint32(data[offset+8 : offset+12])
-		offset += 12
-
-		if noteType != 3 { // NT_STAPSDT
-			// Skip this note
-			nameEnd := offset + int((namesz+3)&^3) // align to 4 bytes
-			descEnd := nameEnd + int((descsz+3)&^3)
-			offset = descEnd
-			continue
-		}
-
-		// Skip owner name (should be "stapsdt")
-		nameEnd := offset + int((namesz+3)&^3)
-
-		if nameEnd+int(descsz) > len(data) {
-			break
-		}
-
-		// Parse descriptor
-		desc := data[nameEnd : nameEnd+int(descsz)]
-		if len(desc) < 24 { // 3 uint64 values
-			offset = nameEnd + int((descsz+3)&^3)
-			continue
-		}
-
-		location := binary.LittleEndian.Uint64(desc[0:8])
-		noteBase := binary.LittleEndian.Uint64(desc[8:16])
-		semaphore := binary.LittleEndian.Uint64(desc[16:24])
-
-		// Apply prelink adjustment if .stapsdt.base section exists
-		// See: https://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation
-		if baseAddr != 0 && noteBase != 0 {
-			diff := baseAddr - noteBase
-			location += diff
-			if semaphore != 0 {
-				semaphore += diff
-			}
-		}
-
-		// Convert virtual address to file offset for uprobe attachment
-		prog := f.findVirtualAddressProg(location)
-		if prog != nil {
-			location = location - prog.Vaddr + prog.Off
-		}
-
-		// Convert semaphore virtual address to file offset
-		var semaphoreFileOffset uint64
-		if semaphore != 0 {
-			semaProg := f.findVirtualAddressProg(semaphore)
-			if semaProg != nil {
-				semaphoreFileOffset = semaphore - semaProg.Vaddr + semaProg.Off
+	sections := make([]usdt.ELFSection, len(r.f.Sections))
+	for i, s := range r.f.Sections {
+		sections[i] = usdt.ELFSection{
+			Name: s.Name,
+			Addr: s.Addr,
+		}
+		// Only read data for sections the parser needs
+		if s.Name == ".note.stapsdt" || s.Name == ".stapsdt.base" {
+			data, err := s.Data(16 * 1024)
+			if err != nil {
+				return nil, err
 			}
+			sections[i].Data = data
 		}
+	}
+	return sections, nil
+}
 
-		// Parse strings: provider\0probe\0arguments\0
-		stringData := desc[24:]
-		strings := strings.Split(string(stringData), "\x00")
-		if len(strings) >= 3 {
-			probe := USDTProbe{
-				Provider:        strings[0],
-				Name:            strings[1],
-				Location:        location,
-				Base:            noteBase,
-				SemaphoreOffset: semaphoreFileOffset,
-				Arguments:       strings[2],
-			}
-			probes = append(probes, probe)
+func (r *pfelfELFReader) LoadSegments() []usdt.ELFProg {
+	var segs []usdt.ELFProg
+	for _, p := range r.f.Progs {
+		if elf.ProgType(p.Type) == elf.PT_LOAD {
+			segs = append(segs, usdt.ELFProg{
+				Vaddr: p.Vaddr,
+				Memsz: p.Memsz,
+				Off:   p.Off,
+			})
 		}
-
-		offset = nameEnd + int((descsz+3)&^3)
 	}
+	return segs
+}
 
-	return probes, nil
+// ParseUSDTProbes reads USDT probe information from ELF .note.stapsdt section.
+// It delegates to the usdt package via the pfelf adapter.
+func (f *File) ParseUSDTProbes() ([]usdt.Probe, error) {
+	return usdt.ParseProbes(&pfelfELFReader{f: f})
 }