Sample frames to include column information in addition to line numbers#177
Draft
manojVivek wants to merge 1 commit intomainfrom
Draft
Sample frames to include column information in addition to line numbers#177manojVivek wants to merge 1 commit intomainfrom
manojVivek wants to merge 1 commit intomainfrom
Conversation
umanwizard
approved these changes
Dec 10, 2025
Comment on lines
+1478
to
+1480
| } else { | ||
| lineStart = 0 | ||
| } |
Collaborator
There was a problem hiding this comment.
The else block is unnecessary as uninitialized variables are 0 by default in go.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains: