node: search for non-exported symbols directly in the symtab#188
Open
umanwizard wants to merge 1 commit intomainfrom
Open
node: search for non-exported symbols directly in the symtab#188umanwizard wants to merge 1 commit intomainfrom
umanwizard wants to merge 1 commit intomainfrom
Conversation
When symbols are not exported, we need to find them by scanning the symtab directly rather than using DT_GNU_HASH and similar mechanisms. The symbols we need are not exported in v24.11.1 and higher; this commit fixes that issue.
Collaborator
Author
|
segfaults in tests might be due to open-telemetry#877 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When symbols are not exported, we need to find them by scanning the symtab directly rather than using DT_GNU_HASH and similar mechanisms.
The symbols we need are not exported in v24.11.1 and higher; this commit fixes that issue.