Skip to content

Various Lua fixes#248

Merged
umanwizard merged 16 commits intomainfrom
lua-cframe
Apr 16, 2026
Merged

Various Lua fixes#248
umanwizard merged 16 commits intomainfrom
lua-cframe

Conversation

@umanwizard
Copy link
Copy Markdown
Collaborator

@umanwizard umanwizard commented Apr 9, 2026

The main fixes are as follows:

  • Document and make clear that hitting the bottom of the Lua stack is an unexpected condition (due to dummy values)
  • Always return to the native unwinder from a cframe. Previously we didn't do so in the case that it was the root cframe (implicitly relying on the fact that we would then unwind into the dummy values described above on the next iteration, where we would then return to the native unwinder anyway).
  • Fix the spadjust value for jit frames on aarch64
  • Always unwind past the native frame when returning to the native unwinder.

@umanwizard umanwizard changed the title Lua refactors. Various Lua fixes Apr 9, 2026
@umanwizard umanwizard requested a review from gnurizen April 9, 2026 22:34
@umanwizard umanwizard marked this pull request as ready for review April 10, 2026 22:07
Comment thread support/ebpf/luajit_tracer.ebpf.c Outdated
Comment thread support/ebpf/luajit_tracer.ebpf.c Outdated
Comment thread support/ebpf/luajit_tracer.ebpf.c
local x = i * i
end
ngx.say(debug.traceback())
-- ngx.say(debug.traceback())
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably just delete this

@umanwizard umanwizard requested a review from gnurizen April 15, 2026 21:35
@umanwizard umanwizard merged commit e54fbd5 into main Apr 16, 2026
37 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants