Conversation
Problem 1 was the real problem and is was just the compiler using a register to write a zero instead of an immediate. Problem 2 was a secondary problem where our simple extraction logic with symbols didn't match our more complex logic w/o symbols. This was due to a broken call pattern match utility that didn't properly detect the AABA call pattern. Testing done with local shared library. Extraction into proper unit tests will come in a follow on PR.
brancz
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1 was the real problem and is was just the compiler using a
register to write a zero instead of an immediate.
Problem 2 was a secondary problem where our simple extraction logic
with symbols didn't match our more complex logic w/o symbols. This
was due to a broken call pattern match utility that didn't properly
detect the AABA call pattern.
Testing done with local shared library. Extraction into proper unit
tests will come in a follow on PR.