Skip to content

Commit cc2cf81

Browse files
committed
Review comment addressed
1 parent 8717c2a commit cc2cf81

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

reporter/parca_reporter.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1443,9 +1443,15 @@ func (r *ParcaReporter) buildStacktraceRecord(ctx context.Context, stacktraceIDs
14431443
if filePath == "" {
14441444
filePath = "UNKNOWN"
14451445
}
1446-
if frame.Mapping.Valid() && frame.Mapping.Value().File.Value().GnuBuildID != "" {
1447-
w.MappingFile.AppendString(frame.Mapping.Value().File.Value().FileName.String())
1448-
w.MappingBuildID.AppendString(frame.Mapping.Value().File.Value().GnuBuildID)
1446+
if frame.Mapping.Valid() {
1447+
file := frame.Mapping.Value().File.Value()
1448+
if file.GnuBuildID != "" {
1449+
w.MappingFile.AppendString(file.FileName.String())
1450+
w.MappingBuildID.AppendString(file.GnuBuildID)
1451+
} else {
1452+
w.MappingFile.AppendString(frameKind.String())
1453+
w.MappingBuildID.AppendNull()
1454+
}
14491455
} else {
14501456
w.MappingFile.AppendString(frameKind.String())
14511457
w.MappingBuildID.AppendNull()

0 commit comments

Comments
 (0)