Add purged state for debuginfo cleanup (#6030)

* Add purged state for debuginfo uploads

This commit introduces a new STATE_PURGED state to track debuginfo that
has been cleaned up from storage. This allows the system to:

1. Signal to users that debuginfo existed but was purged/cleaned up
2. Allow re-uploading of purged debuginfo
3. Prevent symbolization attempts with purged debuginfo

Changes:
- Add STATE_PURGED enum value to proto definition
- Update generated Go and TypeScript code
- Add MarkAsPurged method to ObjectStoreMetadata
- Handle purged state in ShouldInitiateUpload (allows re-upload)
- Handle purged state in symbolizer (returns ErrDebuginfoPurged)
- Add ErrDebuginfoPurged error definition

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

Author: 3 people

gen/proto/go/parca/debuginfo/v1alpha1/debuginfo.pb.go

@@ -26,6 +26,7 @@ import (
 var (
 	ErrUnknownDebuginfoSource = errors.New("unknown debuginfo source")
 	ErrNotUploadedYet         = errors.New("debuginfo not uploaded yet")
+	ErrDebuginfoPurged        = errors.New("debuginfo has been purged")
 )
 
 type Fetcher struct {

pkg/debuginfo/fetcher.go

@@ -105,6 +105,21 @@ func (m *ObjectStoreMetadata) MarkAsUploaded(ctx context.Context, buildID, uploa
 	return m.write(ctx, dbginfo)
 }
 
+func (m *ObjectStoreMetadata) MarkAsPurged(ctx context.Context, buildID string, typ debuginfopb.DebuginfoType) error {
+	dbginfo, err := m.Fetch(ctx, buildID, typ)
+	if err != nil {
+		return err
+	}
+
+	if dbginfo.Upload == nil {
+		return ErrUploadMetadataNotFound
+	}
+
+	dbginfo.Upload.State = debuginfopb.DebuginfoUpload_STATE_PURGED
+
+	return m.write(ctx, dbginfo)
+}
+
 func (m *ObjectStoreMetadata) Fetch(ctx context.Context, buildID string, typ debuginfopb.DebuginfoType) (*debuginfopb.Debuginfo, error) {
 	path := metadataObjectPath(buildID, typ)
 	r, err := m.bucket.Get(ctx, path)

pkg/debuginfo/metadata.go

@@ -126,6 +126,7 @@ const (
 	ReasonDebuginfoInvalid                = "Debuginfo already exists but is marked as invalid, therefore a new upload is needed. Hash the debuginfo and initiate the upload."
 	ReasonDebuginfoEqual                  = "Debuginfo already exists and is marked as invalid, but the proposed hash is the same as the one already available, therefore the upload is not accepted as it would result in the same invalid debuginfos."
 	ReasonDebuginfoNotEqual               = "Debuginfo already exists but is marked as invalid, therefore a new upload will be accepted."
+	ReasonDebuginfoPurged                 = "Debuginfo was previously uploaded but has been purged/cleaned up, therefore a new upload is needed."
 	ReasonDebuginfodSource                = "Debuginfo is available from debuginfod already and not marked as invalid, therefore no new upload is needed."
 	ReasonDebuginfodInvalid               = "Debuginfo is available from debuginfod already but is marked as invalid, therefore a new upload is needed."
 )
@@ -237,6 +238,12 @@ func (s *Store) ShouldInitiateUpload(ctx context.Context, req *debuginfopb.Shoul
 					ShouldInitiateUpload: true,
 					Reason:               ReasonDebuginfoNotEqual,
 				}, nil
+			case debuginfopb.DebuginfoUpload_STATE_PURGED:
+				// Debuginfo was purged, allow re-uploading
+				return &debuginfopb.ShouldInitiateUploadResponse{
+					ShouldInitiateUpload: true,
+					Reason:               ReasonDebuginfoPurged,
+				}, nil
 			default:
 				return nil, status.Error(codes.Internal, "metadata inconsistency: unknown upload state")
 			}

pkg/debuginfo/store.go

@@ -202,7 +202,12 @@ func (s *Symbolizer) getDebuginfo(ctx context.Context, buildID string) (string,
 
 	switch dbginfo.Source {
 	case debuginfopb.Debuginfo_SOURCE_UPLOAD:
-		if dbginfo.Upload.State != debuginfopb.DebuginfoUpload_STATE_UPLOADED {
+		switch dbginfo.Upload.State {
+		case debuginfopb.DebuginfoUpload_STATE_UPLOADED:
+			// Good to proceed
+		case debuginfopb.DebuginfoUpload_STATE_PURGED:
+			return "", nil, nil, debuginfo.ErrDebuginfoPurged
+		default:
 			return "", nil, nil, debuginfo.ErrNotUploadedYet
 		}
 	case debuginfopb.Debuginfo_SOURCE_DEBUGINFOD:

pkg/symbolizer/symbolizer.go

@@ -230,6 +230,8 @@ message DebuginfoUpload {
     STATE_UPLOADING = 1;
     // The debuginfo has been uploaded successfully.
     STATE_UPLOADED = 2;
+    // The debuginfo has been purged/cleaned up from storage.
+    STATE_PURGED = 3;
   }
 
   // State is the current state of the debuginfo upload.

proto/parca/debuginfo/v1alpha1/debuginfo.proto

@@ -423,7 +423,13 @@ export enum DebuginfoUpload_State {
      *
      * @generated from protobuf enum value: STATE_UPLOADED = 2;
      */
-    UPLOADED = 2
+    UPLOADED = 2,
+    /**
+     * The debuginfo has been purged/cleaned up from storage.
+     *
+     * @generated from protobuf enum value: STATE_PURGED = 3;
+     */
+    PURGED = 3
 }
 /**
  * DebuginfoQuality is the quality of the debuginfo.