Security: External stylesheet import can weaken CSP and leak client metadata#6292
Open
tuanaiseo wants to merge 1 commit intoparca-dev:mainfrom
Open
Conversation
The CSS imports Google Fonts from a third-party origin at runtime. This introduces external network dependency and can expose user IP/user-agent/referrer metadata to the third party. In hardened deployments, this often conflicts with strict CSP and privacy requirements. Affected files: profile.css Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Contributor
|
Thanks for the PR! However, this only removes the Google Fonts A complete migration would need to:
Happy to review a revised PR that includes all three steps! |
Contributor
|
Hey @tuanaiseo, just following up on this. It's been about a week with no update. If you're still interested in completing this, happy to wait a bit longer. Otherwise I'll close this and put up a complete PR myself. Let me know either way! |
yomete
added a commit
that referenced
this pull request
Apr 13, 2026
Replace the runtime @import of Google Fonts with self-hosted woff2 files served from public/fonts/. This removes the external network dependency and prevents leaking client metadata (IP, user-agent, referrer) to third-party origins, improving CSP compatibility and privacy. - Bundle Poppins (weights 100-600) and Roboto Mono (400) as woff2 - Add @font-face declarations pointing to local files - Remove the Google Fonts @import - Include OFL license file for bundled fonts Relates to #6292 Signed-off-by: Yomi <yomi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CSS imports Google Fonts from a third-party origin at runtime. This introduces external network dependency and can expose user IP/user-agent/referrer metadata to the third party. In hardened deployments, this often conflicts with strict CSP and privacy requirements.
Severity:
lowFile:
ui/packages/app/web/src/style/profile.cssSolution
Self-host required fonts and serve them from the same origin. Update CSP to restrict
style-src/font-srcto trusted origins only, ideally eliminating third-party font/CDN dependencies.Changes
ui/packages/app/web/src/style/profile.css(modified)Testing