fix geth startup in docker-compose#24
Open
sznicolas wants to merge 1 commit into
Open
Conversation
O1ahmad
reviewed
Jan 23, 2022
| geth: | ||
| image: parithoshj/geth:merge-d99ac5a | ||
| container_name: geth | ||
| ports: |
There was a problem hiding this comment.
Definitely simpler to use host network mode here rather than listing all ports (so uber nit/probably outside the design) but wondering what the thought is with something like: https://github.com/0x0I/container-file-geth/blob/master/compose/docker-compose.yml#L21 to potentially avoid local port conflicts and enable port customization.
Could be not worth having to think about tho the defaults basically yield the same result as host networking and each envvar can also just be set within the operator's runtime env (e.g. via something like export rpc_port=8545) or either set within a .env file processed by default or a custom file passed with docker-compose up provided alternate host ports are desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things fixed in this PR:
network_mode="host"Fatal: Failed to create the protocol stack: datadir already used by another processCan be solved by adding a condition in the depends_on.