Skip to content

fix geth startup in docker-compose #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sznicolas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix geth startup in docker-compose #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions scripts/quick-run/merge-devnets/docker-compose.geth.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ services:
geth:
image: parithoshj/geth:merge-d99ac5a
container_name: geth
ports:

@O1ahmad O1ahmad Jan 23, 2022 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely simpler to use host network mode here rather than listing all ports (so uber nit/probably outside the design) but wondering what the thought is with something like: https://github.com/0x0I/container-file-geth/blob/master/compose/docker-compose.yml#L21 to potentially avoid local port conflicts and enable port customization.

Could be not worth having to think about tho the defaults basically yield the same result as host networking and each envvar can also just be set within the operator's runtime env (e.g. via something like export rpc_port=8545) or either set within a .env file processed by default or a custom file passed with docker-compose up provided alternate host ports are desired.

- "8545:8545"
depends_on:
- init_geth
init_geth:
condition: service_completed_successfully
volumes:
- ./execution_data:/execution_data
command: >
Expand Down