This repository was archived by the owner on Feb 26, 2020. It is now read-only.
use parity fork of hidapi#5
Merged
Merged
Conversation
|
Shouldn't you also update the submodule? Edit: I guess you were waiting for me to merge the other PR :P |
Author
|
yes! I was waiting :) |
Author
|
pr updated! |
andresilva
approved these changes
Jul 12, 2018
niklasad1
pushed a commit
to niklasad1/hidapi-rs
that referenced
this pull request
Feb 23, 2019
niklasad1
pushed a commit
to niklasad1/hidapi-rs
that referenced
this pull request
Feb 23, 2019
Fixed issue paritytech#5 & some minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this parity issue has been open for months: openethereum/parity-ethereum#7542
the fix is straightforward: signal11/hidapi#359
but the hidapi library is unmaintained: signal11/hidapi#373
so I created a fork and am applying the fix to the fork: paritytech/hidapi#1