test(e2e): strengthen mod happy-path test to cover the full clone flow

The previous version of this test verified `exitCode === 0` and that a
slug-prefix directory existed with a `package.json`. That assertion
would pass even if `dot mod` invented an arbitrary `package.json` from
thin air and silently skipped both setup.sh and the side effects of
the source-download step.

`dot mod`'s flow has three steps (see src/commands/mod/SetupScreen.tsx):

  1. fetch app metadata
  2. download source — extract tarball + writeDotJson + ignoreModLogs
     + stripPostinstall + createOptionalGitBaseline
  3. run setup.sh (or warn if absent)

Steps 2's side effects and step 3 weren't observed at all. Strengthen
the test to assert on:

- multiple specific files from the upstream paritytech/Rock-Paper-
  Scissors fixture (README.md, setup.sh, src/, vite.config.ts) — proves
  the GitHub tarball was actually fetched and extracted, not invented.
- dot.json was written with the expected `domain` (relative slug-suffix
  path, per writeDotJson()) and `name` fields.
- .gitignore contains the mod-log entries appended by ignoreModLogs().
- .dot-mod-setup.log exists with `[setup]`-prefixed content from the
  fixture's setup.sh — proves step 3 ran, not just that the file was
  copied across.

Bumped the per-test timeout 180s → 240s to give setup.sh's `npm
install` enough headroom on a cold cache. Same fixture, no new
registration needed.

Author: ottovlotto

e2e/cli/mod.test.ts

@@ -11,7 +11,7 @@
  */
 
 import { describe, test, expect, afterEach } from "vitest";
-import { existsSync, mkdtempSync, readdirSync, rmSync } from "node:fs";
+import { existsSync, mkdtempSync, readdirSync, readFileSync, rmSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 import { dot } from "./helpers/dot.js";
@@ -37,16 +37,20 @@ afterEach(() => {
 
 describe("dot mod — clone", () => {
 	test.skipIf(!TEST_DOMAIN)(
-		"clones the registered template into a fresh directory",
-		{ timeout: 180_000 },
+		"full clone flow: fetches source, runs setup.sh, writes dot.json",
+		{ timeout: 240_000 },
 		async () => {
 			const cwd = makeTempDir("dot-e2e-mod-cwd-");
 			const result = await dot(["mod", TEST_DOMAIN, "--suri", ALICE.suri], {
 				cwd,
-				timeout: 180_000,
+				timeout: 240_000,
 			});
 
-			expect(result.exitCode).toBe(0);
+			expect(
+				result.exitCode,
+				`mod failed:\n${result.stdout}\n${result.stderr}`,
+			).toBe(0);
+
 			// defaultRepoName slugifies the domain and appends a 6-hex suffix.
 			const slug = TEST_DOMAIN.replace(/\.dot$/, "")
 				.toLowerCase()
@@ -55,7 +59,56 @@ describe("dot mod — clone", () => {
 				(name) => name.startsWith(`${slug}-`) && /-[0-9a-f]{6}$/.test(name),
 			);
 			expect(created).toHaveLength(1);
-			expect(existsSync(join(cwd, created[0]!, "package.json"))).toBe(true);
+			const projectDir = join(cwd, created[0]!);
+
+			// ── Step 2 (download source) — content from GitHub ─────────────
+			// Asserting on multiple specific files proves the tarball was
+			// actually fetched and extracted, not invented from thin air.
+			// All four files are committed to paritytech/Rock-Paper-Scissors's
+			// default branch — if any go missing, the upstream fixture has
+			// been restructured and this test needs updating to match.
+			expect(existsSync(join(projectDir, "package.json"))).toBe(true);
+			expect(existsSync(join(projectDir, "README.md"))).toBe(true);
+			expect(existsSync(join(projectDir, "setup.sh"))).toBe(true);
+			expect(existsSync(join(projectDir, "vite.config.ts"))).toBe(true);
+
+			// ── Step 2 side effect: writeDotJson() ─────────────────────────
+			const dotJsonPath = join(projectDir, "dot.json");
+			expect(existsSync(dotJsonPath)).toBe(true);
+			const dotJson = JSON.parse(readFileSync(dotJsonPath, "utf-8")) as {
+				domain?: string;
+				name?: string;
+			};
+			// `domain` is set to `targetDir` in writeDotJson() — and
+			// `targetDir` flows from defaultRepoName(), which returns a
+			// RELATIVE slug-suffix path (e.g. `dot-cli-mod-fixture-a3b2c1`),
+			// not an absolute one. So dotJson.domain should equal the leaf
+			// directory name, NOT projectDir. (Field name is unusual but
+			// documented in src/commands/mod/SetupScreen.tsx.)
+			expect(dotJson.domain).toBe(created[0]);
+			expect(dotJson.name).toBeDefined();
+
+			// ── Step 2 side effect: ignoreModLogs() ────────────────────────
+			const gitignore = readFileSync(
+				join(projectDir, ".gitignore"),
+				"utf-8",
+			);
+			expect(gitignore).toContain(".dot-mod-setup.log");
+			expect(gitignore).toContain(".dot-mod-source.log");
+
+			// ── Step 3 (run setup.sh) ──────────────────────────────────────
+			// The script's first line of substantive output is
+			// `echo "[setup] Rock Paper Scissors tutorial"`. If the log file
+			// exists with that prefix, setup.sh actually ran. (We can't
+			// assert exit 0 of the script here — exit-code propagation is
+			// already covered by the outer `result.exitCode` check above.)
+			const setupLog = join(projectDir, ".dot-mod-setup.log");
+			expect(
+				existsSync(setupLog),
+				`setup.sh log not found — step 3 did not run.\n${result.stdout}\n${result.stderr}`,
+			).toBe(true);
+			const setupLogContent = readFileSync(setupLog, "utf-8");
+			expect(setupLogContent).toContain("[setup]");
 		},
 	);