chore(funder): derive dedicated funder at bare root; fix CI comment order

Follow-up to the env-secret funder change:

- funder.ts: derive the dedicated funder at the bare root (empty derivation
  path) instead of //0, so the funded account matches the signing path;
  replace the address cast with a real null narrow in FUNDER_CHAIN
- funder.test.ts: pin the derivation path with a frozen bare-root vector so a
  path regression fails loudly
- e2e/e2e-release/e2e-post-release workflows: reword comments to describe the
  dedicated funder as primary and Alice as the fallback (matches the new order)
- docs/e2e-bootstrap.md + changeset: reflect the bare-root primary funder

Author: UtkarshBhardwaj007

.changeset/funder-seed-env.md

@@ -4,6 +4,7 @@
 
 The dedicated testnet funder seed is no longer hardcoded in the binary. It is
 read from the `MASTER_FUNDER_SEED` environment variable (CI injects it from a
-repository secret); when unset, funding falls back to Alice alone. This affects
-only the E2E suite and operator tooling — no end-user command funds from this
-chain.
+repository secret); when unset, funding falls back to Alice alone. The dedicated
+funder is now the primary account (drawn down ahead of public Alice) and is
+derived at the bare root (empty derivation path). This affects only the E2E
+suite and operator tooling — no end-user command funds from this chain.

.github/workflows/e2e-post-release.yml

@@ -90,8 +90,9 @@ jobs:
               env:
                   DOT_TAG: e2e-ci-post-release
                   DOT_TELEMETRY: "1"
-                  # Dedicated-funder seed for globalSetup's SIGNER top-up
-                  # fallback. Absent → Alice only.
+                  # Dedicated-funder seed — the primary account globalSetup
+                  # tops up SIGNER from, ahead of the Alice fallback. Absent →
+                  # Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
 
             - name: Upload forensic artefacts

.github/workflows/e2e-release.yml

@@ -79,8 +79,9 @@ jobs:
                   DOT_E2E_BINARY: ${{ github.workspace }}/bin/dot-linux-x64
                   DOT_TAG: e2e-ci-release
                   DOT_TELEMETRY: "1"
-                  # Dedicated-funder seed for globalSetup's SIGNER top-up
-                  # fallback. Absent → Alice only.
+                  # Dedicated-funder seed — the primary account globalSetup
+                  # tops up SIGNER from, ahead of the Alice fallback. Absent →
+                  # Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
 
             - name: Upload forensic artefacts

.github/workflows/e2e.yml

@@ -70,8 +70,9 @@ jobs:
                   DOT_DEPLOY_VERBOSE: "1"
                   DOT_TAG: ${{ steps.setup.outputs.tag }}
                   DOT_TELEMETRY: "1"
-                  # Seed for the dedicated funder, the fallback globalSetup uses
-                  # to top up SIGNER once Alice drains. Absent → Alice only.
+                  # Seed for the dedicated funder, the primary account
+                  # globalSetup tops up SIGNER from (drawn down before public
+                  # Alice, the fallback). Absent → Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
 
             - name: Surface failure detail
@@ -168,8 +169,9 @@ jobs:
                   DOT_DEPLOY_VERBOSE: "1"
                   DOT_TAG: ${{ steps.setup.outputs.tag }}
                   DOT_TELEMETRY: "1"
-                  # Seed for the dedicated funder, the fallback globalSetup uses
-                  # to top up SIGNER once Alice drains. Absent → Alice only.
+                  # Seed for the dedicated funder, the primary account
+                  # globalSetup tops up SIGNER from (drawn down before public
+                  # Alice, the fallback). Absent → Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
 
             - name: Surface failure detail
@@ -231,8 +233,9 @@ jobs:
                   DOT_DEPLOY_VERBOSE: "1"
                   DOT_TAG: ${{ steps.setup.outputs.tag }}
                   DOT_TELEMETRY: "1"
-                  # Seed for the dedicated funder, the fallback globalSetup uses
-                  # to top up SIGNER once Alice drains. Absent → Alice only.
+                  # Seed for the dedicated funder, the primary account
+                  # globalSetup tops up SIGNER from (drawn down before public
+                  # Alice, the fallback). Absent → Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
                   # nightly-deploy-moddable creates a fresh public repo in
                   # paritytech/ each run + pushes the fixture into it. Other
@@ -315,8 +318,9 @@ jobs:
                   DOT_DEPLOY_VERBOSE: "1"
                   DOT_TAG: ${{ steps.setup.outputs.tag }}
                   DOT_TELEMETRY: "1"
-                  # Seed for the dedicated funder, the fallback globalSetup uses
-                  # to top up SIGNER once Alice drains. Absent → Alice only.
+                  # Seed for the dedicated funder, the primary account
+                  # globalSetup tops up SIGNER from (drawn down before public
+                  # Alice, the fallback). Absent → Alice only.
                   MASTER_FUNDER_SEED: ${{ secrets.MASTER_FUNDER_SEED }}
 
             - name: Surface failure detail

docs/e2e-bootstrap.md

@@ -62,10 +62,11 @@ After a registry-contract redeploy, the next CI run restores them automatically.
 
 `MASTER_FUNDER_SEED` is a BIP-39 mnemonic read at runtime by
 `src/utils/account/funder.ts` (env var, never hardcoded). It derives the
-dedicated funder at `//0`, which is the **primary** funder — the chain draws it
-down first and falls back to public Alice only when it's empty. When unset the
-chain is just Alice — fine for offline/local runs, but CI must set it. Provide
-it to local runs with `export MASTER_FUNDER_SEED=…`.
+dedicated funder at the bare root (empty derivation path), which is the
+**primary** funder — the chain draws it down first and falls back to public
+Alice only when it's empty. When unset the chain is just Alice — fine for
+offline/local runs, but CI must set it. Provide it to local runs with
+`export MASTER_FUNDER_SEED=…`.
 
 `GITHUB_TOKEN` (auto-provided) is used by the report job and cleanup cron.
 
@@ -115,7 +116,7 @@ Nothing to do manually. `globalSetup` (`e2e/cli/setup/fund.ts`) and
 Alice as the fallback.
 
 If both the dedicated funder and Alice are empty, re-fund the dedicated funder
-account (the `//0`-derived address — run `bun run scripts/check-funder-balance.ts`
+account (the bare-root address — run `bun run scripts/check-funder-balance.ts`
 with the seed exported to print it) on Paseo, and update the secret if the seed
 itself changed.
 

src/utils/account/funder.test.ts

@@ -28,6 +28,13 @@ import { describe, it, expect, afterEach, vi } from "vitest";
 
 const VALID_MNEMONIC = "bottom drive obey lake curtain smoke basket hold race lonely fit walk";
 
+// Frozen bare-root (empty derivation path) address of VALID_MNEMONIC. Pins the
+// derivation path so a regression back to `//0` (or any other junction) fails
+// loudly: the funder is funded at the bare root, and a path drift would silently
+// move the signer to an unfunded account. `//0` of this mnemonic is a DIFFERENT
+// address (5D34dL5…), so this vector genuinely guards the path.
+const VALID_MNEMONIC_BARE_ROOT = "5DfhGyQdFobKM8NsWvEeAKk5EQQgYe9AydgJ7rMB6E1EqRzV";
+
 afterEach(() => {
     delete process.env.MASTER_FUNDER_SEED;
     vi.resetModules();
@@ -50,8 +57,9 @@ describe("FUNDER_CHAIN dedicated-funder gating", () => {
 
         // Dedicated funder is tried first; Alice is the fallback.
         expect(FUNDER_CHAIN.map((f) => f.name)).toEqual(["dedicated", "Alice"]);
-        // Address is derived from the seed and matches the leading chain entry.
-        expect(DEDICATED_FUNDER_ADDRESS).toMatch(/^5/);
+        // Derived at the bare root (empty path) and matches the leading entry.
+        // The frozen vector pins the derivation path against `//0` regressions.
+        expect(DEDICATED_FUNDER_ADDRESS).toBe(VALID_MNEMONIC_BARE_ROOT);
         expect(FUNDER_CHAIN[0]?.address).toBe(DEDICATED_FUNDER_ADDRESS);
     });
 

src/utils/account/funder.ts

@@ -41,13 +41,13 @@ import { ss58Encode } from "@parity/product-sdk-address";
 import { type Env, getChainConfig } from "../../config.js";
 
 /**
- * Dedicated testnet funder, derived at `//0` from the `MASTER_FUNDER_SEED`
- * env var (a BIP-39 mnemonic). `null` when the var is unset/blank — callers
- * then fall back to Alice alone. Derived once at module load so we don't
- * re-run BIP-39 + sr25519 on every access.
+ * Dedicated testnet funder, derived at the bare root (empty derivation path)
+ * from the `MASTER_FUNDER_SEED` env var (a BIP-39 mnemonic). `null` when the
+ * var is unset/blank — callers then fall back to Alice alone. Derived once at
+ * module load so we don't re-run BIP-39 + sr25519 on every access.
  */
 const dedicatedSeed = process.env.MASTER_FUNDER_SEED?.trim();
-const dedicated = dedicatedSeed ? seedToAccount(dedicatedSeed, "//0") : null;
+const dedicated = dedicatedSeed ? seedToAccount(dedicatedSeed, "") : null;
 const dedicatedAddress = dedicated ? ss58Encode(dedicated.publicKey) : null;
 
 export interface Funder {
@@ -68,11 +68,11 @@ export interface Funder {
  * `MASTER_FUNDER_SEED` is configured; without it the chain is Alice-only.
  */
 export const FUNDER_CHAIN: readonly Funder[] = [
-    ...(dedicated
+    ...(dedicated && dedicatedAddress
         ? [
               {
                   name: "dedicated",
-                  address: dedicatedAddress as string,
+                  address: dedicatedAddress,
                   signer: dedicated.signer,
               },
           ]