fix(deploy): skip phone-event wrap when signer source is 'dev'#105
Merged
Conversation
…session' For `dot deploy --signer dev --suri X --playground`, the session-key funding step previously wrapped the SURI signer with `wrapSignerWithEvents`, emitting a "📱 Approve on your phone" message even though the keypair signs in-process with no human interaction. Mirrors the guard already present in signerMode.ts:121 — only emit phone-tap lifecycle events when `userSigner.source === "session"`. A non-null signer with `source === "dev"` signs directly; null falls through to pickFunder.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic UX fix:
dot deploy --signer dev --suri X --playgroundno longer prints "📱 Approve on your phone: Fund contract deploy session key" for the session-key funding step. The dev keypair signs directly in-process, matching the existing approvals-count guard insignerMode.ts:121which already excludes non-session signers from the phone-tap count.Three-way branch
source === 'session'(real phone): wrap with events, emit lifecycle messagessource === 'dev'(local keypair, any--suri): sign directly, no eventsnull(pure dev): pickFunder from dev chainCloses
The cosmetic half of #94 (the "phone prompt in dev mode" observation). The actual hardhat AccountUnmapped failure remains tracked separately.
Test plan
source === 'dev'branch: asserts raw signer identity, zero signing events emitted, pickFunder not called