ci: use parity-default runners in paritytech org#120
Merged
Conversation
EnderOfWorlds007
force-pushed
the
issue/88-parity-default-runners
branch
from
0e98ac1 to
9bc73a8
Compare
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
EnderOfWorlds007
force-pushed
the
issue/88-parity-default-runners
branch
from
f376330 to
0b7185d
Compare
Contributor
|
Dev build ready — try this branch: |
All jobs now use `parity-default` when running under paritytech and fall back to `ubuntu-latest` for forks, matching the pattern adopted in bulletin-deploy.
EnderOfWorlds007
force-pushed
the
issue/88-parity-default-runners
branch
from
0b7185d to
46419fb
Compare
parity-default runners don't pre-install gh or wget. Replace wget with curl in the E2E setup action, and add a conditional gh install step in each workflow that calls it.
3 tasks
ottovlotto
added a commit
that referenced
this pull request
May 5, 2026
- init-cold-smoke: switch runs-on to the parity-default conditional expression added in #120 (was the only ubuntu-latest literal left in the file). Tighten the failed-row grep: the previous " error" / " failed" substring match would also trip on benign output like "0 errors" and apt warnings; now anchor on "✕ "/"✗ " rendered by the dot TUI plus the literal "failed dependency" marker. Add a comment confirming `bun run src/index.ts` is intentional — it matches the entry path used by the e2e/cli/ vitest suite (per CLAUDE.md), and the published-binary install is covered separately by e2e-post-release.yml. - deploy.test.ts ordering check: the previous regex /\n>\s+\w/ also matches build-tool stdout that the CLI pipes through (pnpm prints `> @scope/pkg@1 build /path` for every run-script, vite logs `> built in 234ms`, etc.). Anchor on the dot CLI's exact banner format `\n> (pnpm|npm|yarn|bun|npx) ` from src/commands/build.ts:15 + src/utils/build/detect.ts so unrelated `> ` lines can't satisfy it. - init.test.ts toolchain detection: drop the timing-based 12s window in favour of forcing the rustup install to fail deterministically via HTTPS_PROXY=http://127.0.0.1:1 (curl's connection-refused is ~instant). The test's contract is that init should not falsely conclude rustup is installed when PATH is stripped — that no longer depends on whether a cache makes the real install fast. Cold-start install success is covered separately by the smoke job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88
Summary
runs-on: ubuntu-latestentries across 8 workflow files replaced with the conditional expression${{ github.repository_owner == 'paritytech' && 'parity-default' || 'ubuntu-latest' }}ubuntu-latestautomaticallyTest plan
parity-defaultrunner)ubuntu-latest(expression falls back correctly)